src: prepare for v8 sandboxing #58376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/some-v8-sandbox-preparations
branch
from
d21804d to
474cba4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/some-v8-sandbox-preparations
branch
from
474cba4 to
fd4f0e7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
May 18, 2025
legendecas
approved these changes
May 18, 2025
addaleax
reviewed
May 18, 2025
jasnell
force-pushed
the
jasnell/some-v8-sandbox-preparations
branch
from
fd4f0e7 to
d9af9b2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
May 19, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung
reviewed
May 19, 2025
jasnell
force-pushed
the
jasnell/some-v8-sandbox-preparations
branch
from
d9af9b2 to
48346dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/some-v8-sandbox-preparations
branch
from
48346dc to
6514931
Compare
jasnell
added a commit
that referenced
this pull request
May 26, 2025
PR-URL: #58376 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in a430ef5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the v8 sandbox is enabled (possibly at some point in the future) all ArrayBuffer allocations must be done within the isolate. Externally allocated backing stores are not permitted. This starts to prepare for that by adding some compile time branches to copy some external buffers rather than wrapping them. We also disable the
--secure-heapfeature since that fundamentally doesn't make sense and can't be supported with v8 sandbox enabled.This PR cannot yet include additional tests for the new branches largely because we cannot yet build node with v8 sandbox enabled.