test: remove loop over single element #58368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This loop used to iterate over two elements, but since commit 215f4d0, it only iterates over a single element. Therefore, move the test out of the loop body and remove the loop itself. Refs: nodejs#50973
tniessen
added
crypto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58368 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.01%
==========================================
Files 633 633
Lines 186859 186860 +1
Branches 36685 36684 -1
==========================================
- Hits 168622 168619 -3
- Misses 11036 11046 +10
+ Partials 7201 7195 -6 🚀 New features to boost your workflow:
|
panva
approved these changes
May 17, 2025
lpinca
approved these changes
May 17, 2025
LiviaMedeiros
approved these changes
May 17, 2025
LiviaMedeiros
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
May 17, 2025
juanarbol
approved these changes
May 18, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eab4ccf |
targos
pushed a commit
that referenced
this pull request
May 31, 2025
This loop used to iterate over two elements, but since commit 215f4d0, it only iterates over a single element. Therefore, move the test out of the loop body and remove the loop itself. Refs: #50973 PR-URL: #58368 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
This loop used to iterate over two elements, but since commit 215f4d0, it only iterates over a single element. Therefore, move the test out of the loop body and remove the loop itself. Refs: #50973 PR-URL: #58368 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loop used to iterate over two elements, but since commit 215f4d0, it only iterates over a single element. Therefore, move the test out of the loop body and remove the loop itself.
Refs: #50973