benchmark: add callback-based fs.glob to glob benchmark

[LiviaMedeiros]

No description provided.

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[H4ad]

I think we should build the options object outside the loop

[LiviaMedeiros]

Sure, implemented in 531d6be

[H4ad]

Maybe add one version with util.promisify

[LiviaMedeiros]

I don't really think so. It will make the benchmark run longer while giving no real benefit (we already measure the underlying callback-based function in this PR, and promisifying callback-based function makes little sense when promise-based function exists).

[H4ad]

We can also move this callback method to outside the loop

[LiviaMedeiros]

Implemented in 531d6be (whole function since we need the resolve and reject)

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/58417
✔  Done loading data for nodejs/node/pull/58417
----------------------------------- PR info ------------------------------------
Title      benchmark: add callback-based `fs.glob` to glob benchmark (#58417)
Author     Livia Medeiros <livia@cirno.name> (@LiviaMedeiros)
Branch     LiviaMedeiros:benchmark-glob-callback -> nodejs:main
Labels     fs, benchmark, author ready
Commits    3
 - benchmark: add callback-based `fs.glob` to glob benchmark
 - squash: optimize benchmark
 - squash: lint
Committers 1
 - LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/58417
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58417
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 22 May 2025 09:31:57 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/58417#pullrequestreview-2862149112
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58417#pullrequestreview-2862502908
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   c3b580d9f0..6c9a7cd61e  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 4f4ad11aa9 lib: make ERM functions into wrappers returning undefined
 - 6c9a7cd61e lib: make ERM functions into wrappers returning undefined
--------------------------------------------------------------------------------
HEAD is now at 6c9a7cd61e lib: make ERM functions into wrappers returning undefined
   ✔  Reset to origin/main
- Downloading patch for 58417
From https://github.com/nodejs/node
 * branch                  refs/pull/58417/merge -> FETCH_HEAD
✔  Fetched commits as 6c9a7cd61ef4..959390764419
--------------------------------------------------------------------------------
[main 6b1bc6c0fe] benchmark: add callback-based `fs.glob` to glob benchmark
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Thu May 22 17:29:44 2025 +0800
 1 file changed, 21 insertions(+), 5 deletions(-)
[main 5eb38eb92e] squash: optimize benchmark
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Fri May 23 01:52:50 2025 +0800
 1 file changed, 18 insertions(+), 12 deletions(-)
[main 1922a94554] squash: lint
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Fri May 23 03:44:14 2025 +0800
 1 file changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
benchmark: add callback-based `fs.glob` to glob benchmark
PR-URL: #58417

Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
[detached HEAD 32b28eb0bc] benchmark: add callback-based fs.glob to glob benchmark

Author: LiviaMedeiros <livia@cirno.name>

Date: Thu May 22 17:29:44 2025 +0800

1 file changed, 21 insertions(+), 5 deletions(-)

Rebasing (3/6)

Rebasing (4/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

squash: optimize benchmark
PR-URL: #58417

Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
[detached HEAD 1d461bc026] squash: optimize benchmark

Author: LiviaMedeiros <livia@cirno.name>

Date: Fri May 23 01:52:50 2025 +0800

1 file changed, 18 insertions(+), 12 deletions(-)

Rebasing (5/6)

Rebasing (6/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

squash: lint
PR-URL: #58417

Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
[detached HEAD abbc440ff7] squash: lint

Author: LiviaMedeiros <livia@cirno.name>

Date: Fri May 23 03:44:14 2025 +0800

1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/15238503394

[nodejs-github-bot]

Landed in fa8816a

[aduh95]

benchmark/fs/bench-glob.js does not exist on v22.x