Skip to content

report: use uv_getrusage_thread in report #58405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

theanarkh
Copy link
Contributor

use uv_getrusage_thread in report.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels May 20, 2025
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would require bumping the report version number (see the docs) and potentially updating the examples in the docs.

Nevermind, this is not adding something new.

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (b0cf2e2) to head (1e6a4a4).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
src/node_report.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58405      +/-   ##
==========================================
- Coverage   90.23%   90.20%   -0.04%     
==========================================
  Files         633      635       +2     
  Lines      186860   187171     +311     
  Branches    36681    36750      +69     
==========================================
+ Hits       168613   168832     +219     
- Misses      11044    11117      +73     
- Partials     7203     7222      +19     
Files with missing lines Coverage Δ
src/node_report.cc 93.23% <0.00%> (ø)

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 21, 2025
@theanarkh theanarkh force-pushed the use_uv_getrusage_thread_in_report branch 3 times, most recently from 1e66275 to ceb4827 Compare May 21, 2025 15:27
@theanarkh theanarkh force-pushed the use_uv_getrusage_thread_in_report branch from ceb4827 to 1e6a4a4 Compare May 21, 2025 15:41
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit 74acfdf into main May 22, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 74acfdf

@nodejs-github-bot nodejs-github-bot deleted the use_uv_getrusage_thread_in_report branch May 22, 2025 17:10
Asiermosquera

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants