Skip to content

Commit 44df21b

Browse files
hkleungaitargos
authored andcommitted
zlib: remove mentions of unexposed Z_TREES constant
`Z_TREES` is never exposed on `DefineZlibConstants()`, hence it shall be removed. This fix is applicable to v18+. Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc PR-URL: #58371 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent adef9af commit 44df21b

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

doc/api/zlib.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,6 @@ Allowed flush values.
615615
* `zlib.constants.Z_FULL_FLUSH`
616616
* `zlib.constants.Z_FINISH`
617617
* `zlib.constants.Z_BLOCK`
618-
* `zlib.constants.Z_TREES`
619618

620619
Return codes for the compression/decompression functions. Negative
621620
values are errors, positive values are used for special but normal

lib/zlib.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ ZlibBase.prototype._final = function(callback) {
307307
// This is currently only used to figure out which flush flag to use for the
308308
// last chunk.
309309
// Roughly, the following holds:
310-
// Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
310+
// Z_NO_FLUSH < Z_BLOCK < Z_PARTIAL_FLUSH <
311311
// Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
312312
const flushiness = [];
313313
const kFlushFlagList = [Z_NO_FLUSH, Z_BLOCK, Z_PARTIAL_FLUSH,

0 commit comments

Comments
 (0)