[v22.x backport] worker: make Worker async disposable #58455
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
needs-ci
jasnell
changed the title
|
Maybe it is quite irrelevant, but this backport diverges a bit from the original PR (one extra commit) and each commit is missing its metadata (trailing, same as the original PR). |
|
This was a manual commit put together before the other one landed. Will update it with the metadata later. |
Manual Backport of nodejs#58385 Original metadata: PR-URL: nodejs#58385 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
jasnell
force-pushed
the
jasnell/backport-worker-dispose
branch
from
23474ab to
a8ffbcd
Compare
There was a problem hiding this comment.
This was a manual commit put together before the other one landed. Will update it with the metadata later.
Oh, I see. Although, all commits needs its trailers. I think a rebase and a ncu command for each patch will fix it. I'm approving considering that you'll add the git trailers for each commit as it should be.
|
i'm not planning on back porting both of the original commits since one is only relevant for 24.x. This one commit combines the base change along the 22.x version of the test that landed in the original. |
aduh95
changed the title
Backport of #58385