Skip to content

doc: add islandryu to collaborators #58714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

doc: add islandryu to collaborators #58714

merged 1 commit into from
Jun 16, 2025

Conversation

islandryu
Copy link
Member

Fixes: #58559

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 15, 2025
@islandryu islandryu added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 15, 2025
@legendecas legendecas added meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @legendecas. Please 👍 to approve.

@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @legendecas.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

RaisinTen
RaisinTen approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome! 🎉

@islandryu islandryu added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4d849a1 into nodejs:main Jun 16, 2025
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4d849a1

targos pushed a commit that referenced this pull request Jun 16, 2025
@islandryu @targos
doc: add islandryu to collaborators
841609a 
Fixes: #58559
PR-URL: #58714
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
nodejs-github-bot added a commit that referenced this pull request Jun 16, 2025
@nodejs-github-bot
2025-06-17, Version 24.3.0 (Current)
8aa0513 
Notable changes:

doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643
test_runner:
  * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438
url:
  * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700

PR-URL: #58727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@legendecas legendecas legendecas approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominate @islandryu as a collaborator
7 participants
@islandryu @nodejs-github-bot @lpinca @joyeecheung @legendecas @RaisinTen @LiviaMedeiros