module: unflag --experimental-strip-types #56350

marco-ippolito · 2024-12-24T15:04:02Z

It's time to enable it by default to catch some more bugs, currently there are no open issues.
I think it's a semver minor change.

Fixes: nodejs/typescript#17

@nodejs/tsc for visibility

Notable change section:

This change enables the flag --experimental-strip-types by default.
Node.js will be able to execute TypeScript files without additional configuration. Note that there are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.

nodejs-github-bot · 2024-12-24T15:04:07Z

Review requested:

@nodejs/loaders
@nodejs/performance
@nodejs/test_runner
@nodejs/typescript

codecov · 2024-12-24T19:38:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (da3f388) to head (d847c32).
Report is 1407 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56350      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         657      657              
  Lines      190655   190658       +3     
  Branches    36582    36584       +2     
==========================================
- Hits       168824   168820       -4     
- Misses      15008    15011       +3     
- Partials     6823     6827       +4

Files with missing lines	Coverage Δ
src/node_options.cc	`87.92% <ø> (ø)`
src/node_options.h	`98.30% <100.00%> (ø)`

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

LGTM

github-actions · 2024-12-25T12:09:44Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2024-12-25T12:12:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64202/

bmuenzenmeyer

excited for this, having watched it's development and played with it quite a bit.
some suggestions and questions, none blocking

doc/api/cli.md

test/es-module/test-typescript.mjs

test/parallel/test-runner-coverage-default-exclusion.mjs

doc/api/cli.md

doc/api/typescript.md

anonrig · 2024-12-26T00:03:35Z

What about process.features.typescript? Does that also needs changing?

marco-ippolito · 2024-12-26T06:05:36Z

What about process.features.typescript? Does that also needs changing?

It works fine, tests are updated (now the default value is 'strip')

PR-URL: #58732 Refs: #56350 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#56350 Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>

PR-URL: #56350 Backport-PR-URL: #57298 Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>

PR-URL: #58175 Backport-PR-URL: #57298 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #56350 Fixes: nodejs/typescript#17

This commit refactors the CommonJS loader to remove TypeScript-specific extensions from the require.extensions object for compatibility with libraries that depended on it to initialize extenal TypeScript loaders. PR-URL: #58657 Backport-PR-URL: #57298 Refs: nodejs/typescript#37 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #58643 Backport-PR-URL: #57298 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #57687 Backport-PR-URL: #57298 Fixes: #56830 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #57704 Backport-PR-URL: #57298 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #57871 Backport-PR-URL: #57298 Fixes: #57471 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #58174 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #58639 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> PR-URL: #56350 Fixes: nodejs/typescript#17

PR-URL: #58754 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> PR-URL: #56350 Fixes: nodejs/typescript#17