Skip to content

doc: recommend watching the collaborators repo in the onboarding doc #57527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

doc: recommend watching the collaborators repo in the onboarding doc #57527

merged 2 commits into from
Mar 20, 2025

Conversation

RaisinTen
Copy link
Member

It might be easy to miss this repo. For example, I forgot rewatching this repo when I rejoined. So it would be a good idea to mention this in the collaborator onboarding guide.

@RaisinTen
doc: recommend watching the collaborators repo in the onboarding doc
2f7f7f1 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 18, 2025
@RaisinTen RaisinTen mentioned this pull request Mar 18, 2025
Merged
aduh95
aduh95 approved these changes Mar 18, 2025
View reviewed changes
@RaisinTen @aduh95
doc: add dot
4a22a9e 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 18, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2025
mcollina
mcollina approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mhdawson
mhdawson approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4c1b876 into nodejs:main Mar 20, 2025
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4c1b876

@RaisinTen RaisinTen deleted the doc/recommend-watching-the-collaborators-repo-in-onboarding-doc branch March 20, 2025 08:05
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@RaisinTen @aduh95
doc: recommend watching the collaborators repo in the onboarding doc
ee60254 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@RaisinTen @RafaelGSS
doc: recommend watching the collaborators repo in the onboarding doc
937d935 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@RaisinTen @RafaelGSS
doc: recommend watching the collaborators repo in the onboarding doc
ea87eaa 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@RaisinTen @RafaelGSS
doc: recommend watching the collaborators repo in the onboarding doc
5611fe1 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@RaisinTen @RafaelGSS
doc: recommend watching the collaborators repo in the onboarding doc
27ca87d 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@RaisinTen @RafaelGSS
doc: recommend watching the collaborators repo in the onboarding doc
372bd62 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@RaisinTen @aduh95
doc: recommend watching the collaborators repo in the onboarding doc
1c26d13 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@RaisinTen @aduh95
doc: recommend watching the collaborators repo in the onboarding doc
062eab4 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@RaisinTen @aduh95
doc: recommend watching the collaborators repo in the onboarding doc
b8eac27 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@RaisinTen @RafaelGSS
doc: recommend watching the collaborators repo in the onboarding doc
3ab9045 
It might be easy to miss this repo. For example, I forgot rewatching
this repo when I rejoined. So it would be a good idea to mention this in
the collaborator onboarding guide.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@legendecas legendecas legendecas approved these changes

@meixg meixg meixg approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.