Skip to content

test: update parallel/test-tls-dhe for OpenSSL 3.5 #57477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

richardlau
Copy link
Member

The output of the s_client command invoked by the test has changed in the OpenSSL 3.5.0 version of s_client. Update the test so that it works with both the old and new output -- the s_client binary being run may not be at the exact same version of OpenSSL as used by Node.js so the updated test allows either output.

Refs: openssl/openssl#26734

The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 15, 2025
@richardlau
Copy link
Member Author

richardlau commented Mar 15, 2025

FWIW I'm working on getting openssl-3.5.0-alpha1 into our CI containers so we can test Node.js dynamically linked to OpenSSL 3.5 (I'll update to the beta when it is released and then to the full release). This test was the only one that failed (on all supported release lines),
e.g. https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/81/

20:22:49 not ok 2994 parallel/test-tls-dhe
20:22:49   ---
20:22:49   duration_ms: 169.41100
20:22:49   severity: fail
20:22:49   exitcode: 1
20:22:49   stack: |-
20:22:49     node:internal/assert/utils:281
20:22:49         throw err;
20:22:49         ^
20:22:49     
20:22:49     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
20:22:49     
20:22:49       assert(keylen === null ||
20:22:49              stdout.includes(`Server Temp Key: DH, ${keylen} bits`))
20:22:49     
20:22:49         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/parallel/test-tls-dhe.js:87:7
20:22:49         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/common/index.js:400:17
20:22:49         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/common/index.js:435:15
20:22:49         at ChildProcess.exithandler (node:child_process:407:7)
20:22:49         at ChildProcess.emit (node:events:507:28)
20:22:49         at maybeClose (node:internal/child_process:1101:16)
20:22:49         at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
20:22:49       generatedMessage: true,
20:22:49       code: 'ERR_ASSERTION',
20:22:49       actual: false,
20:22:49       expected: true,
20:22:49       operator: '=='
20:22:49     }
20:22:49     
20:22:49     Node.js v24.0.0-pre
20:22:49   ...

https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/86/nodes=ubuntu2204_sharedlibs_openssl35_x64/ will hopefully show this test passing with this PR.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (72aa2ea) to head (a75d6b5).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57477      +/-   ##
==========================================
- Coverage   90.22%   90.21%   -0.02%     
==========================================
  Files         629      629              
  Lines      184948   184948              
  Branches    36207    36209       +2     
==========================================
- Hits       166865   166845      -20     
- Misses      11029    11040      +11     
- Partials     7054     7063       +9     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM (EDIT: actually, the CI container has the prove it works, so not ruber stampy)

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 15, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit fab6906 into nodejs:main Mar 17, 2025
79 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fab6906

@richardlau richardlau deleted the openssl35 branch March 17, 2025 13:14
richardlau added a commit to richardlau/build that referenced this pull request Mar 17, 2025
For now, limit testing with OpenSSL 3.5 to Node.js 24 (current `main`)
until test fixes are backported to earlier release lines.

Refs: nodejs/node#57477
richardlau added a commit to richardlau/build that referenced this pull request Mar 21, 2025
For now, limit testing with OpenSSL 3.5 to Node.js 24 (current `main`)
until test fixes are backported to earlier release lines.

Refs: nodejs/node#57477
richardlau added a commit to nodejs/build that referenced this pull request Mar 22, 2025
Add OpenSSL 3.5.0-alpha1 to sharedlibs containers.

For now, limit testing with OpenSSL 3.5 to Node.js 24 (current `main`)
until test fixes are backported to earlier release lines.

Refs: nodejs/node#57477
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Apr 4, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: nodejs#57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants