Skip to content

sqlite: add support for unknown named parameters #57552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

sqlite: add support for unknown named parameters #57552

merged 1 commit into from
Mar 22, 2025
+84 −3

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 20, 2025

This commit adds a method for toggling support for unknown named parameters in prepared statements.

Fixes: #55533

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 20, 2025
@cjihrig
sqlite: add support for unknown named parameters
e6233af 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: nodejs#55533
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (6b42554) to head (e6233af).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57552   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         630      630           
  Lines      185000   185015   +15     
  Branches    36240    36236    -4     
=======================================
+ Hits       166926   166957   +31     
+ Misses      11020    11016    -4     
+ Partials     7054     7042   -12
Files with missing lines Coverage Δ
src/node_sqlite.h 70.00% <ø> (ø)
src/node_sqlite.cc 78.59% <88.88%> (+0.07%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 20, 2025
@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65868/ 💛

@cjihrig cjihrig removed the needs-ci PRs that need a full CI run. label Mar 21, 2025
@Renegade334
Copy link
Contributor

As an aside thought, as the list of per-statement configurable behaviours continues to grow, is there a case for adding an options parameter to DatabaseSync.prototype.prepare()?

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 21, 2025

I would say so. This has been there since the first commit.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit ffc1cf6 into nodejs:main Mar 22, 2025
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ffc1cf6

@cjihrig cjihrig deleted the unknown-params branch March 22, 2025 02:30
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@cjihrig @aduh95
sqlite: add support for unknown named parameters
e8d4a31 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
pandeykushagra51 pushed a commit to pandeykushagra51/node that referenced this pull request Mar 28, 2025
@cjihrig @pandeykushagra51
sqlite: add support for unknown named parameters
1bcb928 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: nodejs#55533
PR-URL: nodejs#57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@cjihrig @RafaelGSS
sqlite: add support for unknown named parameters
9f00dcf 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@cjihrig @RafaelGSS
sqlite: add support for unknown named parameters
b390cd5 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@cjihrig @RafaelGSS
sqlite: add support for unknown named parameters
e693396 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: nodejs#55533
PR-URL: nodejs#57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @RafaelGSS
sqlite: add support for unknown named parameters
5f633c6 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @RafaelGSS
sqlite: add support for unknown named parameters
80fc09f 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @aduh95
sqlite: add support for unknown named parameters
5bc2e24 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @aduh95
sqlite: add support for unknown named parameters
da3653d 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@cjihrig @aduh95
sqlite: add support for unknown named parameters
768bb61 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@cjihrig @RafaelGSS
sqlite: add support for unknown named parameters
5ec955a 
This commit adds a method for toggling support for unknown named
parameters in prepared statements.

Fixes: #55533
PR-URL: #57552
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid sqlite behavior about unused named parameter
5 participants
@cjihrig @nodejs-github-bot @Renegade334 @jasnell @geeksilva97