Skip to content

timers: remove unnecessary allocation of _onTimeout #57497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

timers: remove unnecessary allocation of _onTimeout #57497

merged 1 commit into from
Mar 20, 2025

Conversation

gurgunday
Copy link
Member

This doesn't cause that problem anymore

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 16, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (8a5a849) to head (8fe22b2).
Report is 32 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57497   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         629      629           
  Lines      184847   184844    -3     
  Branches    36207    36208    +1     
=======================================
+ Hits       166780   166787    +7     
- Misses      11015    11023    +8     
+ Partials     7052     7034   -18
Files with missing lines Coverage Δ
lib/internal/timers.js 99.58% <ø> (-0.01%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65843/

@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 02a985d into nodejs:main Mar 20, 2025
71 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 02a985d

@gurgunday gurgunday deleted the remove-allocations branch March 20, 2025 21:47
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@gurgunday @aduh95
timers: remove unnecessary allocation of _onTimeout
d4abd9d 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@gurgunday @RafaelGSS
timers: remove unnecessary allocation of _onTimeout
ac1b0e6 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@gurgunday @RafaelGSS
timers: remove unnecessary allocation of _onTimeout
f3d7fe2 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@gurgunday @RafaelGSS
timers: remove unnecessary allocation of _onTimeout
acd9052 
PR-URL: nodejs#57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @RafaelGSS
timers: remove unnecessary allocation of _onTimeout
06a08dc 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @RafaelGSS
timers: remove unnecessary allocation of _onTimeout
499f6e8 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @aduh95
timers: remove unnecessary allocation of _onTimeout
fd77a11 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @aduh95
timers: remove unnecessary allocation of _onTimeout
13f9c66 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@gurgunday @aduh95
timers: remove unnecessary allocation of _onTimeout
9f21fd4 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@gurgunday @RafaelGSS
timers: remove unnecessary allocation of _onTimeout
a18dcc1 
PR-URL: #57497
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gurgunday @nodejs-github-bot @jasnell @anonrig @Flarna