Skip to content

doc: fix typo in url.md #57467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

doc: fix typo in url.md #57467

merged 1 commit into from
Mar 15, 2025

Conversation

mureinik
Copy link
Contributor

Fix a typo "objg" should be "obj".

Fixes: #57464

@mureinik
doc: fix typo in url.md
e4b549e 
Fix a typo "objg" should be "obj".

Fixes: nodejs#57464
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Mar 14, 2025
@jakecastelli jakecastelli mentioned this pull request Mar 15, 2025
Closed
@benjamingr benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 15, 2025
@aduh95 aduh95 merged commit 2affc3a into nodejs:main Mar 15, 2025
35 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Mar 15, 2025

Landed in 2affc3a

@mureinik mureinik deleted the urlpattern-doc-typo branch March 15, 2025 10:20
aduh95 pushed a commit that referenced this pull request Mar 18, 2025
@mureinik @lawlight-org @aduh95
doc: fix typo in url.md
2a5fcb2 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@mureinik @lawlight-org @RafaelGSS
doc: fix typo in url.md
6e1b6f8 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@mureinik @lawlight-org @RafaelGSS
doc: fix typo in url.md
7d26bba 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@mureinik @lawlight-org @RafaelGSS
doc: fix typo in url.md
30e4b52 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: nodejs#57464
PR-URL: nodejs#57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@mureinik @lawlight-org @RafaelGSS
doc: fix typo in url.md
9768443 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@mureinik @lawlight-org @RafaelGSS
doc: fix typo in url.md
39c76b3 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@mureinik @lawlight-org @aduh95
doc: fix typo in url.md
fc4ad49 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@mureinik @lawlight-org @aduh95
doc: fix typo in url.md
c724dd2 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@mureinik @lawlight-org @aduh95
doc: fix typo in url.md
25f753b 
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <lawlight02@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@daeyeon daeyeon daeyeon approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in URLPattern parameters
6 participants
@mureinik @aduh95 @benjamingr @daeyeon @jakecastelli @nodejs-github-bot