Skip to content

deps: update ada to v3.2.1 and update web-platform tests #57429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Mar 12, 2025

All existing pull-requests were failing and required human intervention to succeed. I'm opening this PR to avoid re-running the CI on 3 different pull-requests.

cc @nodejs/url

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1679/

@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 12, 2025
@anonrig anonrig requested review from lemire and jasnell March 12, 2025 23:52
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 12, 2025
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

@anonrig anonrig force-pushed the yagiz/update-ada-to-v321-latest branch from e71812c to 6c9f6ea Compare March 13, 2025 00:48
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (a0139e0) to head (6c9f6ea).
Report is 223 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57429      +/-   ##
==========================================
- Coverage   90.21%   90.21%   -0.01%     
==========================================
  Files         629      629              
  Lines      184984   184983       -1     
  Branches    36211    36214       +3     
==========================================
- Hits       166887   166881       -6     
- Misses      11043    11044       +1     
- Partials     7054     7058       +4     
Files with missing lines Coverage Δ
src/node_url_pattern.cc 82.12% <ø> (-0.04%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig requested review from targos and aduh95 March 13, 2025 16:04
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2025
@anonrig
Copy link
Member Author

anonrig commented Mar 13, 2025

Thank you for the review @atlowChemi

@anonrig
Copy link
Member Author

anonrig commented Mar 14, 2025

@mcollina A "std::move()" on a url_pattern_init struct improves the performance by 1%. I say that shows promise that regex parsing doesn't dominate the profile that much :-))

22:30:09 url/urlpattern-parse.js n=100000 pattern='"https://(sub.)?example(.com/)foo"'                                                           **     -0.66 %       ±0.39% ±0.51% ±0.67%
22:30:09 url/urlpattern-parse.js n=100000 pattern='{"hostname":"xn--caf-dma.com"}'                                                                      -0.30 %       ±0.32% ±0.43% ±0.56%
22:30:09 url/urlpattern-parse.js n=100000 pattern='{"pathname":"/([[a-z]--a])"}'                                                                 **     -0.43 %       ±0.25% ±0.33% ±0.43%
22:30:09 url/urlpattern-parse.js n=100000 pattern='{"pathname":"/foo","search":"bar","hash":"baz","baseURL":"https://example.com:8080"}'        ***      0.74 %       ±0.25% ±0.34% ±0.44%
22:30:09 url/urlpattern-test.js n=100000 pattern='"https://(sub.)?example(.com/)foo"'                                                                   -0.53 %       ±0.67% ±0.89% ±1.16%
22:30:09 url/urlpattern-test.js n=100000 pattern='{"hostname":"xn--caf-dma.com"}'                                                                       -0.81 %       ±0.88% ±1.17% ±1.53%
22:30:09 url/urlpattern-test.js n=100000 pattern='{"pathname":"/([[a-z]--a])"}'                                                                  **     -1.17 %       ±0.68% ±0.91% ±1.19%
22:30:09 url/urlpattern-test.js n=100000 pattern='{"pathname":"/foo","search":"bar","hash":"baz","baseURL":"https://example.com:8080"}'                  0.71 %       ±1.07% ±1.43% ±1.87%

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit 72aa2ea into nodejs:main Mar 14, 2025
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 72aa2ea

aduh95 pushed a commit that referenced this pull request Mar 18, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
PR-URL: nodejs#57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
PR-URL: #57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants