Skip to content

Update --require docs #57620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

Update --require docs #57620

merged 3 commits into from
Mar 28, 2025

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 25, 2025

With require(esm) being unflagged, node --require module now also supports ES modules.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Mar 25, 2025
aduh95
aduh95 reviewed Mar 25, 2025
View reviewed changes
@aduh95 aduh95 added the lts-watch-v20.x PRs that may need to be released in v20.x label Mar 25, 2025
@JLHwung @aduh95
Update doc/api/cli.md
ebc6854 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 25, 2025
@ljharb ljharb added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Mar 26, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 28, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/57620
✔  Done loading data for nodejs/node/pull/57620
----------------------------------- PR info ------------------------------------
Title      Update `--require` docs (#57620)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     JLHwung:patch-1 -> nodejs:main
Labels     doc, cli, author ready, commit-queue-squash, dont-land-on-v18.x, lts-watch-v20.x
Commits    3
 - doc: `--require module` supports ES modules
 - update pr url
 - Update doc/api/cli.md
Committers 2
 - Huáng Jùnliàng <jlhwung@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
TypeError: Cannot read properties of undefined (reading 'oid')
    at file:///opt/hostedtoolcache/node/22.14.0/x64/lib/node_modules/@node-core/utils/lib/pr_checker.js:548:81
    at Array.findLastIndex (<anonymous>)
    at PRChecker.getApprovedTipOfHead (file:///opt/hostedtoolcache/node/22.14.0/x64/lib/node_modules/@node-core/utils/lib/pr_checker.js:548:8)
    at PRChecker.checkCommitsAfterReview (file:///opt/hostedtoolcache/node/22.14.0/x64/lib/node_modules/@node-core/utils/lib/pr_checker.js:572:19)
    at PRChecker.checkAll (file:///opt/hostedtoolcache/node/22.14.0/x64/lib/node_modules/@node-core/utils/lib/pr_checker.js:85:12)
    at getMetadata (file:///opt/hostedtoolcache/node/22.14.0/x64/lib/node_modules/@node-core/utils/components/metadata.js:41:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async main (file:///opt/hostedtoolcache/node/22.14.0/x64/lib/node_modules/@node-core/utils/components/git/land.js:204:22)
https://github.com/nodejs/node/actions/runs/14125110480

@aduh95 aduh95 mentioned this pull request Mar 28, 2025
Merged
@aduh95 aduh95 merged commit c922bd8 into nodejs:main Mar 28, 2025
34 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Mar 28, 2025

Landed in c922bd8

@JLHwung JLHwung deleted the patch-1 branch March 28, 2025 13:07
aduh95 pushed a commit that referenced this pull request Mar 28, 2025
@JLHwung @aduh95
doc: remove mention of --require not supporting ES modules
99dbd8b 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@JLHwung @RafaelGSS
doc: remove mention of --require not supporting ES modules
88075e2 
PR-URL: nodejs#57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@JLHwung @RafaelGSS
doc: remove mention of --require not supporting ES modules
d6f6201 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@JLHwung @RafaelGSS
doc: remove mention of --require not supporting ES modules
748b727 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@JLHwung @aduh95
doc: remove mention of --require not supporting ES modules
5395cc3 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@JLHwung @aduh95
doc: remove mention of --require not supporting ES modules
16bd863 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@JLHwung @aduh95
doc: remove mention of --require not supporting ES modules
a6deeb2 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@JLHwung @RafaelGSS
doc: remove mention of --require not supporting ES modules
4fb2352 
PR-URL: #57620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@JLHwung @nodejs-github-bot @aduh95 @ljharb @jasnell @lpinca @joyeecheung @UlisesGascon @marco-ippolito @atlowChemi