Skip to content

timers: remove unused parameter from insertGuarded #57251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

timers: remove unused parameter from insertGuarded #57251

merged 1 commit into from
Mar 12, 2025
+2 −2

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Mar 1, 2025 •
edited
Loading

insert has a third optional parameter and sometimes it's called with 2 arguments instead of 3

This is not the case for insertGuarded, its third parameter is never used and the function is not exported, so it's safe to remove

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 1, 2025
juanarbol
juanarbol approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (db4dcc0) to head (4ecc702).
Report is 100 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57251   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         630      630           
  Lines      184921   184921           
  Branches    36185    36187    +2     
=======================================
+ Hits       166879   166883    +4     
+ Misses      11065    11055   -10     
- Partials     6977     6983    +6
Files with missing lines Coverage Δ
lib/internal/timers.js 99.59% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65529/

@gurgunday
Copy link
Member Author

Can we add an author-ready? :)

@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit a0139e0 into nodejs:main Mar 12, 2025
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a0139e0

@gurgunday gurgunday deleted the insertguarded branch March 12, 2025 22:35
aduh95 pushed a commit that referenced this pull request Mar 18, 2025
@gurgunday @aduh95
timers: remove unused parameter from insertGuarded
f8f81c8 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@gurgunday @RafaelGSS
timers: remove unused parameter from insertGuarded
a8518df 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@gurgunday @RafaelGSS
timers: remove unused parameter from insertGuarded
028297f 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@gurgunday @RafaelGSS
timers: remove unused parameter from insertGuarded
a262ada 
PR-URL: nodejs#57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @RafaelGSS
timers: remove unused parameter from insertGuarded
a8db342 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @RafaelGSS
timers: remove unused parameter from insertGuarded
8b46070 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @aduh95
timers: remove unused parameter from insertGuarded
3d3a326 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@gurgunday @aduh95
timers: remove unused parameter from insertGuarded
6e4ebd1 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@gurgunday @aduh95
timers: remove unused parameter from insertGuarded
a5e7e88 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@gurgunday @RafaelGSS
timers: remove unused parameter from insertGuarded
aa4add6 
PR-URL: #57251
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gurgunday @nodejs-github-bot @lpinca @juanarbol @jakecastelli