win,test: disable test case failing with ClangCL #57397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
added
windows
|
Fast-track has been requested by @StefanStojanovic. Please 👍 to approve. |
StefanStojanovic
force-pushed
the
mefi-clang-test-fix
branch
from
5378cc8 to
d2a1e5f
Compare
StefanStojanovic
force-pushed
the
mefi-clang-test-fix
branch
from
d2a1e5f to
941a3e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57397 +/- ##
==========================================
- Coverage 90.21% 90.21% -0.01%
==========================================
Files 630 630
Lines 185213 185213
Branches 36240 36243 +3
==========================================
- Hits 167096 167094 -2
+ Misses 11057 11054 -3
- Partials 7060 7065 +5 🚀 New features to boost your workflow:
|
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Mar 11, 2025
lpinca
approved these changes
Mar 11, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 59f00d7 |
aduh95
pushed a commit
that referenced
this pull request
Mar 18, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Apr 8, 2025
PR-URL: nodejs#57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 14, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 14, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 14, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 14, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 15, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #57397 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables a
SIGQUITtest case on Windows fortest-child-process-kill.js. As it can be seen from the CI results, this is the only blocker for enabling tests for ClangCL binaries on all CI runs. IMHO, this is a worthy trade-off.In addition, this is a temporary thing as I plan to investigate it further and re-enable it ASAP. This problem does not exist when compiling Node.js on the latest Windows 10. Our CI compilation machines use Windows 2022 (Windows 11 basically), so the issue is Windows version specific, and I didn't experience it a few months ago.
I am currently reinstalling my Windows 11 machine (talk about bad timing...), so I should be able to investigate it there later this week.
I'll also request fast tracking, as the change is trivial.
After investigating, I will decide on how to approach it, there is the Node.js part and the libuv part here. Ideally, the fix will be on the Node.js side if feasible. This can be easily done by treating
SIGQUITasSIGKILL, but I'd like to keep possibility of using it on Windows if possible, as that is a possibility now.