timers: optimize timer functions with improved argument handling #57072

gurgunday · 2025-02-15T17:25:50Z

After:

timers/immediate.js
timers/immediate.js type="depth" n=5000000: 80,080.39740943641
timers/immediate.js type="depth1" n=5000000: 81,172.49117847806
timers/immediate.js type="breadth" n=5000000: 6,043,891.345759598
timers/immediate.js type="breadth1" n=5000000: 3,625,307.3296283777
timers/immediate.js type="breadth4" n=5000000: 3,390,438.1071638097
timers/immediate.js type="clear" n=5000000: 17,872,894.015227303

timers/set-immediate-breadth-args.js
timers/set-immediate-breadth-args.js n=5000000: 2,719,426.8722150475

timers/set-immediate-breadth.js
timers/set-immediate-breadth.js n=10000000: 5,408,182.94584942

timers/set-immediate-depth-args.js
timers/set-immediate-depth-args.js n=5000000: 81,470.89492708661

timers/timers-breadth-args.js
timers/timers-breadth-args.js n=1000000: 2,293,034.7427874957

timers/timers-breadth.js
timers/timers-breadth.js n=5000000: 3,560,692.234861032

timers/timers-cancel-pooled.js
timers/timers-cancel-pooled.js n=5000000: 26,070,668.11238602

timers/timers-cancel-unpooled.js
timers/timers-cancel-unpooled.js direction="start" n=1000000: 4,025,027.621752054
timers/timers-cancel-unpooled.js direction="end" n=1000000: 23,885,540.68014507

timers/timers-depth.js
timers/timers-depth.js n=1000: 871.7480297332925

timers/timers-insert-pooled.js
timers/timers-insert-pooled.js n=5000000: 3,114,655.0450797137

timers/timers-insert-unpooled.js
timers/timers-insert-unpooled.js direction="start" n=1000000: 3,866,726.810766608
timers/timers-insert-unpooled.js direction="end" n=1000000: 2,321,271.5229021

timers/timers-timeout-nexttick.js
timers/timers-timeout-nexttick.js n=50000: 3,159,308.1115235765
timers/timers-timeout-nexttick.js n=5000000: 6,083,459.279596363

timers/timers-timeout-pooled.js
timers/timers-timeout-pooled.js n=10000000: 18,978,540.19786525

timers/timers-timeout-unpooled.js
timers/timers-timeout-unpooled.js n=1000000: 18,657,978.268119812

Before:

gurgunday@Gurguns-MacBook-Air node % node benchmark/run.js timers              

timers/immediate.js
timers/immediate.js type="depth" n=5000000: 78,882.93004449889
timers/immediate.js type="depth1" n=5000000: 79,208.86810881029
timers/immediate.js type="breadth" n=5000000: 5,475,245.614097755
timers/immediate.js type="breadth1" n=5000000: 3,418,192.2343457905
timers/immediate.js type="breadth4" n=5000000: 2,220,066.291179455
timers/immediate.js type="clear" n=5000000: 16,625,836.383481566

timers/set-immediate-breadth-args.js
timers/set-immediate-breadth-args.js n=5000000: 2,484,761.063515046

timers/set-immediate-breadth.js
timers/set-immediate-breadth.js n=10000000: 5,217,361.020062365

timers/set-immediate-depth-args.js
timers/set-immediate-depth-args.js n=5000000: 78,881.00406705718

timers/timers-breadth-args.js
timers/timers-breadth-args.js n=1000000: 2,320,253.8066240572

timers/timers-breadth.js
timers/timers-breadth.js n=5000000: 3,627,726.0207083295

timers/timers-cancel-pooled.js
timers/timers-cancel-pooled.js n=5000000: 28,413,416.044484362

timers/timers-cancel-unpooled.js
timers/timers-cancel-unpooled.js direction="start" n=1000000: 3,928,022.9082296006
timers/timers-cancel-unpooled.js direction="end" n=1000000: 22,356,256.425188098

timers/timers-depth.js
timers/timers-depth.js n=1000: 871.8493679691478

timers/timers-insert-pooled.js
timers/timers-insert-pooled.js n=5000000: 2,885,978.1773654805

timers/timers-insert-unpooled.js
timers/timers-insert-unpooled.js direction="start" n=1000000: 3,951,745.894772246
timers/timers-insert-unpooled.js direction="end" n=1000000: 2,249,549.459109555

timers/timers-timeout-nexttick.js
timers/timers-timeout-nexttick.js n=50000: 3,015,908.91955063
timers/timers-timeout-nexttick.js n=5000000: 6,165,632.315873412

timers/timers-timeout-pooled.js
timers/timers-timeout-pooled.js n=10000000: 16,896,694.03508683

timers/timers-timeout-unpooled.js
timers/timers-timeout-unpooled.js n=1000000: 16,643,169.56249218

gurgunday · 2025-02-15T17:28:53Z

However, I recommend merging this version with the latest commit (5bf7e26) to not have holey arrays and for consistency

gurgunday@Gurguns-MacBook-Air node % ./out/Release/node benchmark/run.js timers

timers/immediate.js
timers/immediate.js type="depth" n=5000000: 80,468.347887105
timers/immediate.js type="depth1" n=5000000: 80,273.09887569316
timers/immediate.js type="breadth" n=5000000: 5,866,096.091053544
timers/immediate.js type="breadth1" n=5000000: 3,582,319.354496545
timers/immediate.js type="breadth4" n=5000000: 3,268,553.8642968345
timers/immediate.js type="clear" n=5000000: 18,280,959.14708357

timers/set-immediate-breadth-args.js
timers/set-immediate-breadth-args.js n=5000000: 3,078,123.9392592525

timers/set-immediate-breadth.js
timers/set-immediate-breadth.js n=10000000: 5,286,463.315563438

timers/set-immediate-depth-args.js
timers/set-immediate-depth-args.js n=5000000: 79,877.45100246496

timers/timers-breadth-args.js
timers/timers-breadth-args.js n=1000000: 2,770,819.9410369517

timers/timers-breadth.js
timers/timers-breadth.js n=5000000: 4,216,864.783787456

timers/timers-cancel-pooled.js
timers/timers-cancel-pooled.js n=5000000: 29,206,432.148907755

timers/timers-cancel-unpooled.js
timers/timers-cancel-unpooled.js direction="start" n=1000000: 4,021,420.094131391
timers/timers-cancel-unpooled.js direction="end" n=1000000: 23,927,666.663675707

timers/timers-depth.js
timers/timers-depth.js n=1000: 877.6599768611793

timers/timers-insert-pooled.js
timers/timers-insert-pooled.js n=5000000: 2,833,107.3812150676

timers/timers-insert-unpooled.js
timers/timers-insert-unpooled.js direction="start" n=1000000: 3,502,887.6930419514
timers/timers-insert-unpooled.js direction="end" n=1000000: 2,340,635.853484566

timers/timers-timeout-nexttick.js
timers/timers-timeout-nexttick.js n=50000: 2,621,409.534003561
timers/timers-timeout-nexttick.js n=5000000: 6,167,875.059683906

timers/timers-timeout-pooled.js
timers/timers-timeout-pooled.js n=10000000: 19,414,833.68972917

timers/timers-timeout-unpooled.js
timers/timers-timeout-unpooled.js n=1000000: 16,475,878.465418886

codecov · 2025-02-15T18:54:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (fd45383) to head (703dedd).
Report is 199 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57072      +/-   ##
==========================================
+ Coverage   90.26%   90.27%   +0.01%     
==========================================
  Files         630      630              
  Lines      184634   184560      -74     
  Branches    36137    36111      -26     
==========================================
- Hits       166654   166606      -48     
- Misses      11022    11023       +1     
+ Partials     6958     6931      -27

Files with missing lines	Coverage Δ
lib/timers.js	`100.00% <100.00%> (ø)`

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lpinca · 2025-02-23T19:48:20Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1659/

atlowChemi · 2025-02-23T20:25:05Z

Benchmark CI: ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1659

                                                             confidence improvement accuracy (*)   (**)   (***)
timers/immediate.js type='breadth' n=5000000                        ***     -7.56 %       ±2.29% ±3.08%  ±4.08%
timers/immediate.js type='breadth1' n=5000000                               -0.72 %       ±1.15% ±1.53%  ±1.99%
timers/immediate.js type='breadth4' n=5000000                       ***     40.00 %       ±1.92% ±2.58%  ±3.41%
timers/immediate.js type='clear' n=5000000                          ***     -6.54 %       ±1.40% ±1.86%  ±2.42%
timers/immediate.js type='depth' n=5000000                          ***      1.32 %       ±0.61% ±0.82%  ±1.06%
timers/immediate.js type='depth1' n=5000000                                 -0.04 %       ±0.72% ±0.95%  ±1.24%
timers/set-immediate-breadth-args.js n=5000000                      ***     18.49 %       ±3.89% ±5.20%  ±6.83%
timers/set-immediate-breadth.js n=10000000                            *     -1.30 %       ±1.08% ±1.43%  ±1.87%
timers/set-immediate-depth-args.js n=5000000                        ***      3.67 %       ±0.61% ±0.81%  ±1.06%
timers/timers-breadth-args.js n=1000000                             ***     23.00 %       ±1.78% ±2.37%  ±3.09%
timers/timers-breadth.js n=5000000                                  ***      8.88 %       ±1.58% ±2.10%  ±2.74%
timers/timers-cancel-pooled.js n=5000000                            ***     26.12 %       ±6.18% ±8.23% ±10.74%
timers/timers-cancel-unpooled.js direction='end' n=1000000            *      3.96 %       ±3.77% ±5.07%  ±6.72%
timers/timers-cancel-unpooled.js direction='start' n=1000000         **      3.00 %       ±1.74% ±2.34%  ±3.11%
timers/timers-depth.js n=1000                                               -0.04 %       ±0.15% ±0.20%  ±0.26%
timers/timers-insert-pooled.js n=5000000                             **     -6.73 %       ±4.98% ±6.63%  ±8.63%
timers/timers-insert-unpooled.js direction='end' n=1000000          ***      3.54 %       ±0.93% ±1.25%  ±1.64%
timers/timers-insert-unpooled.js direction='start' n=1000000        ***     10.48 %       ±2.02% ±2.72%  ±3.60%
timers/timers-timeout-nexttick.js n=50000                           ***     -8.83 %       ±3.52% ±4.69%  ±6.10%
timers/timers-timeout-nexttick.js n=5000000                          **      5.25 %       ±3.26% ±4.34%  ±5.65%
timers/timers-timeout-pooled.js n=10000000                            *      0.52 %       ±0.50% ±0.66%  ±0.86%
timers/timers-timeout-unpooled.js n=1000000                         ***     12.27 %       ±3.09% ±4.15%  ±5.48%

nodejs-github-bot · 2025-02-23T20:31:21Z

Commit Queue failed

- Loading data for nodejs/node/pull/57072
✔  Done loading data for nodejs/node/pull/57072
----------------------------------- PR info ------------------------------------
Title      timers: optimize timer functions with improved argument handling (#57072)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     gurgunday:timers-preallocate -> nodejs:main
Labels     timers, needs-ci, needs-benchmark-ci, commit-queue-squash
Commits    5
 - timers: optimize timer functions with improved argument handling
 - avoid holey arrays
 - remove unused import
 - remove unused import
 - jsdoc too
Committers 1
 - Gürgün Dayıoğlu <hey@gurgun.day>
PR-URL: https://github.com/nodejs/node/pull/57072
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57072
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 15 Feb 2025 17:25:50 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57072#pullrequestreview-2619477349
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57072#pullrequestreview-2619481862
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/57072#pullrequestreview-2619492113
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/57072#pullrequestreview-2625769474
   ✔  Last GitHub CI successful
   ✘  No full Jenkins CI runs detected
   ℹ  Last Benchmark CI on 2025-02-23T19:48:20Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1659/
- Querying data for job/node-test-pull-request/1659/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/13486630589

nodejs-github-bot · 2025-02-25T09:25:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65424/

gurgunday · 2025-02-26T21:10:12Z

@atlowChemi can we try again? This shouldn't fail normally

nodejs-github-bot · 2025-02-28T10:26:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65479/

Flarna · 2025-02-28T20:40:10Z

Benchmark CI including latest changes: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1668/

timers/immediate.js type='breadth' n=5000000                        ***     -5.64 %       ±2.29% ±3.07% ±4.05%
timers/immediate.js type='breadth1' n=5000000                               -0.58 %       ±1.10% ±1.46% ±1.90%
timers/immediate.js type='breadth4' n=5000000                       ***     40.89 %       ±2.06% ±2.76% ±3.61%
timers/immediate.js type='clear' n=5000000                          ***     -5.13 %       ±1.20% ±1.61% ±2.10%
timers/immediate.js type='depth' n=5000000                          ***      1.63 %       ±0.91% ±1.21% ±1.57%
timers/immediate.js type='depth1' n=5000000                                  0.52 %       ±1.04% ±1.39% ±1.80%
timers/set-immediate-breadth-args.js n=5000000                      ***     18.84 %       ±4.37% ±5.85% ±7.67%
timers/set-immediate-breadth.js n=10000000                          ***     -2.71 %       ±0.88% ±1.19% ±1.56%
timers/set-immediate-depth-args.js n=5000000                        ***      4.39 %       ±1.02% ±1.36% ±1.78%
timers/timers-breadth-args.js n=1000000                             ***     22.76 %       ±2.18% ±2.90% ±3.78%
timers/timers-breadth.js n=5000000                                   **      4.17 %       ±2.85% ±3.81% ±4.99%
timers/timers-cancel-pooled.js n=5000000                            ***     35.57 %       ±5.24% ±6.99% ±9.15%
timers/timers-cancel-unpooled.js direction='end' n=1000000           **      7.75 %       ±5.05% ±6.81% ±9.03%
timers/timers-cancel-unpooled.js direction='start' n=1000000         **      3.44 %       ±2.17% ±2.92% ±3.87%
timers/timers-depth.js n=1000                                               -0.11 %       ±0.16% ±0.21% ±0.28%
timers/timers-insert-pooled.js n=5000000                                    -1.30 %       ±4.99% ±6.64% ±8.65%
timers/timers-insert-unpooled.js direction='end' n=1000000          ***      2.27 %       ±1.20% ±1.59% ±2.08%
timers/timers-insert-unpooled.js direction='start' n=1000000        ***     10.43 %       ±1.83% ±2.46% ±3.25%
timers/timers-timeout-nexttick.js n=50000                           ***     -8.52 %       ±3.62% ±4.83% ±6.30%
timers/timers-timeout-nexttick.js n=5000000                          **      4.29 %       ±3.18% ±4.24% ±5.53%
timers/timers-timeout-pooled.js n=10000000                           **      0.83 %       ±0.52% ±0.69% ±0.91%
timers/timers-timeout-unpooled.js n=1000000                         ***      9.35 %       ±2.31% ±3.09% ±4.07%

gurgunday · 2025-03-15T21:09:51Z

@lpinca can you take a look if you have time?

nodejs-github-bot · 2025-03-24T20:30:54Z

Landed in 1123585

PR-URL: #57072 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#57072 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #57072 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Feb 15, 2025

gurgunday force-pushed the timers-preallocate branch from dc9268b to 054659b Compare February 15, 2025 17:27

jasnell approved these changes Feb 15, 2025

View reviewed changes

anonrig added needs-benchmark-ci PR that need a benchmark CI run. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 15, 2025

anonrig approved these changes Feb 15, 2025

View reviewed changes

BridgeAR approved these changes Feb 15, 2025

View reviewed changes

mertcanaltin approved these changes Feb 16, 2025

View reviewed changes

atlowChemi approved these changes Feb 19, 2025

View reviewed changes

gurgunday changed the title ~~timers: Optimize timer functions with improved argument handling~~ timers: optimize timer functions with improved argument handling Feb 21, 2025

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 23, 2025

atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 25, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2025

This comment was marked as outdated.

Sign in to view

gurgunday added 5 commits February 26, 2025 22:09

timers: optimize timer functions with improved argument handling

62c5fee

avoid holey arrays

82c1bb7

remove unused import

b8b8b11

remove unused import

30f340b

jsdoc too

703dedd

gurgunday force-pushed the timers-preallocate branch from e2429c1 to 703dedd Compare February 26, 2025 21:09

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2025

This comment was marked as outdated.

Sign in to view

Flarna approved these changes Feb 28, 2025

View reviewed changes

Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2025

lpinca approved these changes Mar 24, 2025

View reviewed changes

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 24, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 24, 2025

nodejs-github-bot merged commit 1123585 into nodejs:main Mar 24, 2025
62 checks passed

github-actions bot mentioned this pull request Mar 30, 2025

2025-04-01, Version 23.11.0 (Current) #57694

Merged

RafaelGSS mentioned this pull request Apr 8, 2025

v22.x-staging cherry-pick status #57799

Open

aduh95 mentioned this pull request Apr 11, 2025

2025-04-16, Version 22.15.0 'Jod' (LTS), @RafaelGSS #57840

Open

gurgunday deleted the timers-preallocate branch April 12, 2025 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

timers: optimize timer functions with improved argument handling #57072

timers: optimize timer functions with improved argument handling #57072

gurgunday commented Feb 15, 2025 •

edited

Loading

gurgunday commented Feb 15, 2025

codecov bot commented Feb 15, 2025 •

edited

Loading

lpinca commented Feb 23, 2025

atlowChemi commented Feb 23, 2025

nodejs-github-bot commented Feb 23, 2025

This comment was marked as outdated.

nodejs-github-bot commented Feb 25, 2025

gurgunday commented Feb 26, 2025

This comment was marked as outdated.

nodejs-github-bot commented Feb 28, 2025

Flarna commented Feb 28, 2025 •

edited

Loading

gurgunday commented Mar 15, 2025

nodejs-github-bot commented Mar 24, 2025

timers: optimize timer functions with improved argument handling #57072

timers: optimize timer functions with improved argument handling #57072

Conversation

gurgunday commented Feb 15, 2025 • edited Loading

gurgunday commented Feb 15, 2025

codecov bot commented Feb 15, 2025 • edited Loading

Codecov Report

lpinca commented Feb 23, 2025

atlowChemi commented Feb 23, 2025

nodejs-github-bot commented Feb 23, 2025

This comment was marked as outdated.

nodejs-github-bot commented Feb 25, 2025

gurgunday commented Feb 26, 2025

This comment was marked as outdated.

nodejs-github-bot commented Feb 28, 2025

Flarna commented Feb 28, 2025 • edited Loading

gurgunday commented Mar 15, 2025

nodejs-github-bot commented Mar 24, 2025

gurgunday commented Feb 15, 2025 •

edited

Loading

codecov bot commented Feb 15, 2025 •

edited

Loading

Flarna commented Feb 28, 2025 •

edited

Loading