Skip to content

sqlite: add DatabaseSync.prototype.isOpen #57522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

sqlite: add DatabaseSync.prototype.isOpen #57522

merged 1 commit into from
Mar 19, 2025
+28 −0

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 17, 2025

This commit adds a getter to indicate whether or not the database is currently open.

Fixes: #57521

@cjihrig
sqlite: add DatabaseSync.prototype.isOpen
3423db1 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: nodejs#57521
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 17, 2025
@cjihrig cjihrig mentioned this pull request Mar 17, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (0cfc471) to head (3423db1).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57522   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         629      629           
  Lines      184845   184852    +7     
  Branches    36206    36217   +11     
=======================================
+ Hits       166766   166780   +14     
+ Misses      11024    11016    -8     
- Partials     7055     7056    +1
Files with missing lines Coverage Δ
src/node_sqlite.h 70.00% <ø> (ø)
src/node_sqlite.cc 78.55% <85.71%> (+0.03%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65808/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65811/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65821/

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Mar 18, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2025
@nodejs-github-bot nodejs-github-bot merged commit 9851388 into nodejs:main Mar 19, 2025
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9851388

@cjihrig cjihrig deleted the is-open branch March 19, 2025 17:07
@cjihrig cjihrig mentioned this pull request Mar 21, 2025
Closed
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@cjihrig @aduh95
sqlite: add DatabaseSync.prototype.isOpen
5652da6 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@cjihrig @RafaelGSS
sqlite: add DatabaseSync.prototype.isOpen
31a67eb 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@cjihrig @RafaelGSS
sqlite: add DatabaseSync.prototype.isOpen
30d8bc6 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@cjihrig @RafaelGSS
sqlite: add DatabaseSync.prototype.isOpen
7d7856a 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: nodejs#57521
PR-URL: nodejs#57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @RafaelGSS
sqlite: add DatabaseSync.prototype.isOpen
f841097 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @RafaelGSS
sqlite: add DatabaseSync.prototype.isOpen
f755e00 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @aduh95
sqlite: add DatabaseSync.prototype.isOpen
3a571c1 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@cjihrig @aduh95
sqlite: add DatabaseSync.prototype.isOpen
5c9a37b 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@cjihrig @aduh95
sqlite: add DatabaseSync.prototype.isOpen
54ee94f 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@cjihrig @RafaelGSS
sqlite: add DatabaseSync.prototype.isOpen
38da655 
This commit adds a getter to indicate whether or not the database
is currently open.

Fixes: #57521
PR-URL: #57522
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:sqlite: need someway to tell if the database is still open
7 participants
@cjihrig @nodejs-github-bot @targos @tniessen @UlisesGascon @geeksilva97 @atlowChemi