Skip to content

doc: clarify --cpu-prof-name allowed values #57433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

doc: clarify --cpu-prof-name allowed values #57433

wants to merge 3 commits into from
+9 −0

Conversation

cecia234
Copy link
Contributor

Added clarification for the --cpu-prof-name cli parameter allowed values.

Refs: #57418

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Mar 13, 2025
mertcanaltin
mertcanaltin reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be healthy to add an example?

@cecia234
Copy link
Contributor Author

Sure! It could be helpful, thanks. Not committing the examples right now since after trying out the parameter there could be some cases in which the templates actually work. I'm waiting for a reply here #57418 (comment)

jasnell
jasnell reviewed Mar 16, 2025
View reviewed changes
jasnell pushed a commit that referenced this pull request Mar 16, 2025
@cecia234 @jasnell
cli: clarify --cpu-prof-name allowed values
8ccbfb6 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2025

Landed in 8ccbfb6

@jasnell jasnell closed this Mar 16, 2025
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@cecia234 @aduh95
cli: clarify --cpu-prof-name allowed values
52cd095 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@cecia234 @RafaelGSS
cli: clarify --cpu-prof-name allowed values
dce9142 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@cecia234 @RafaelGSS
cli: clarify --cpu-prof-name allowed values
c3d7dcb 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@cecia234 @RafaelGSS
cli: clarify --cpu-prof-name allowed values
eeb6068 
Refs: nodejs#57418
PR-URL: nodejs#57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@cecia234 @RafaelGSS
cli: clarify --cpu-prof-name allowed values
1a54835 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@cecia234 @RafaelGSS
cli: clarify --cpu-prof-name allowed values
ddc1c89 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@cecia234 @aduh95
cli: clarify --cpu-prof-name allowed values
fe0c4b3 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@cecia234 @aduh95
cli: clarify --cpu-prof-name allowed values
28fbc5d 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@cecia234 @aduh95
cli: clarify --cpu-prof-name allowed values
e274c9a 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@cecia234 @RafaelGSS
cli: clarify --cpu-prof-name allowed values
f447d0e 
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cecia234 @jasnell @anonrig @mertcanaltin @nodejs-github-bot