Skip to content

debugger: fix behavior of plain object exec in debugger repl #57498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2025
Merged

debugger: fix behavior of plain object exec in debugger repl #57498

merged 3 commits into from
Mar 18, 2025

Conversation

dario-piotrowicz
Copy link
Member

Fixes: #46808

(PS: this is a continuation of #46924 which has been stale for almost a year at this point)

dario-piotrowicz and others added 2 commits March 16, 2025 11:17
@dario-piotrowicz @meixg
debugger: fix behavior of plain object exec in debugger repl
7377a78 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
@dario-piotrowicz
fixup! debugger: fix behavior of plain object exec in debugger repl
146f268 
add `isObjectLiteral` function to share logic
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Mar 16, 2025
anonrig
anonrig approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small perf improvement.

@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (824c6a5) to head (0804e77).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57498      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.02%     
==========================================
  Files         629      629              
  Lines      184955   184867      -88     
  Branches    36215    36217       +2     
==========================================
- Hits       166901   166789     -112     
- Misses      11012    11029      +17     
- Partials     7042     7049       +7
Files with missing lines Coverage Δ
lib/internal/debugger/inspect_repl.js 91.76% <100.00%> (+0.05%) ⬆️
lib/internal/repl/utils.js 96.34% <100.00%> (+0.08%) ⬆️
lib/repl.js 94.89% <100.00%> (-0.02%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowicz
fixup! fixup! debugger: fix behavior of plain object exec in debugger…
0804e77 
… repl

move regexes outside of `isObjectLiteral`
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65785/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65810/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2025
@nodejs-github-bot nodejs-github-bot merged commit 922ce9d into nodejs:main Mar 18, 2025
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 922ce9d

@meixg meixg mentioned this pull request Mar 19, 2025
Closed
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@dario-piotrowicz @meixg @aduh95
debugger: fix behavior of plain object exec in debugger repl
1f08864 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@dario-piotrowicz @meixg @RafaelGSS
debugger: fix behavior of plain object exec in debugger repl
960568e 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@dario-piotrowicz @meixg @RafaelGSS
debugger: fix behavior of plain object exec in debugger repl
a87be00 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@dario-piotrowicz @meixg @RafaelGSS
debugger: fix behavior of plain object exec in debugger repl
c4bf109 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: nodejs#57498
Fixes: nodejs#46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@dario-piotrowicz @meixg @RafaelGSS
debugger: fix behavior of plain object exec in debugger repl
cd7329b 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@dario-piotrowicz @meixg @RafaelGSS
debugger: fix behavior of plain object exec in debugger repl
a559542 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@dario-piotrowicz @meixg @aduh95
debugger: fix behavior of plain object exec in debugger repl
0c06185 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@dario-piotrowicz @meixg @aduh95
debugger: fix behavior of plain object exec in debugger repl
d3d1106 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@dario-piotrowicz @meixg @aduh95
debugger: fix behavior of plain object exec in debugger repl
35c990a 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@dario-piotrowicz @meixg @RafaelGSS
debugger: fix behavior of plain object exec in debugger repl
4479560 
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #57498
Fixes: #46808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@meixg meixg meixg approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different behavior of { a: 1 } in the REPL and the debugger
6 participants
@dario-piotrowicz @nodejs-github-bot @jasnell @anonrig @BridgeAR @meixg