-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Version v10.18.0 RC #15173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version v10.18.0 RC #15173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update chromdriver to v103 * update chrome binary to v103
…ation and failing to import (#15016) * fix tokenIds larger than MAX_SAFE_INTEGER breaking * add tests
…oken transfer functions (#15064) * Ensure that addresses are properly hex-prefixed in the generate ERC token transfer functions * Ensure hex-prefixed addresses in send input * Update unit tests Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Master Sync after v10.16.1
Bumps [@metamask/design-tokens](https://github.com/MetaMask/design-tokens) from 1.6.5 to 1.7.0. - [Release notes](https://github.com/MetaMask/design-tokens/releases) - [Changelog](https://github.com/MetaMask/design-tokens/blob/main/CHANGELOG.md) - [Commits](MetaMask/design-tokens@v1.6.5...v1.7.0) --- updated-dependencies: - dependency-name: "@metamask/design-tokens" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… or does not exist (#15034) * add fallback image/card for collectibles when image was not fetched correctly or does not exist * UI and storybook updates (#15071) * UI and storybook updates * Adding break so token id is displayed * subtle border fix * Updating content * Removing unused image * Adding proptype descriptions * Lint fix Co-authored-by: George Marshall <george.marshall@consensys.net>
* Initial push * Refactored the code * Additional code * Removed the unused message * Added a tooltip * Fixed tests * Lint fix * Added style to a tooltip * Fix e2e test failure * Lint fix and code revert * Fix e2e test * Fixed paddings * Fixed paddings * CSS fix * Minified svg files * Applied requested changes * Fixed theme issue * Code revert * Added back overridden code * Icon problem fixed * Lint fix * Replaced H3 with H4 * Added unit test * Added breadcrumbs * Added const props for networks * Lint fix * Lint fix * Added toggle button for showing the custom network list and resolved few issues * Fixed routes * Refactored a piece of code * Enabled searching for the newly created option * Fixed unit test * Updated theme
Master Sync PR following v10.16.2
…networks and balance is loading (#15116)
* remove global transaction state from send slice * fixup new test
* add e2e test * update variable name * add test for ERC20
* download dir * state logs e2e * update ff version
* fixed e2e tests for new UI * fixed scrolling in tests to be bi-compatible * updated enums to point to new UI version
Master sync following v10.17.0
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
* enhance setApprovalForAll confirmation flow * cleanup * address feedback
* Improve confirm screen tests * Fix transaction controller unit test * Fix unit test fixtures * Fix e2e test
…ct (#13588) * Fix warning dialog when sending tokens to a known token contract address Fixing after rebase Covering missed cases Rebased and ran yarn setup Rebased Fix checkContractAddress condition Lint fix Applied requested changes Fix unit tests Applying requested changes Applied requested changes Refactor and update Lint fix Use V2 of ActionableMessage component Adding Learn More Link Updating warning copy Addressing review feedback Fix up copy changes Simplify validation of pasted addresses Improve detection of whether this is a token contract Refactor to leave updateRecipient unchanged, and to prevent the double calling of update recipient Update tests fix * Fix unit tests * Fix e2e tests * Ensure next button is disabled while recipient type is loading * Add optional chaining and a fallback to getRecipientWarningAcknowledgement * Fix lint * Don't reset recipient warning on asset change, because we should show recipient warnings regardless of asset * Update unit tests * Update unit tests Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
* Changelog 10.18.0 * Remove feature flag commits for popular networks * Remove commit Bump design tokens as has no effect on UI
Collaborator
Author
… and updates type (#15248) * Ensure that editing a transaction from a transfer to a simple send properly resets data and updates type * Handle case where there are no unapproved txes * Improve comment in updateSendAsset * Remove unnecessary code in send transaction edit function * Fix * Ensure hex data is properly reset when changing from a safe transfer from tx to native send
Collaborator
Author
Builds ready [810c00c]Page Load Metrics (1817 ± 70 ms)
highlights:storybook
|
Collaborator
Author
Builds ready [024a62f]Page Load Metrics (1641 ± 31 ms)
highlights:storybook
|
Collaborator
Author
Builds ready [f0556cf]Page Load Metrics (1738 ± 90 ms)
highlights:storybook
|
PeterYinusa
previously approved these changes
Jul 22, 2022
seaona
approved these changes
Jul 22, 2022
Collaborator
Author
Builds ready [74bdf04]Page Load Metrics (1876 ± 128 ms)
highlights:storybook
|
PeterYinusa
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 🚀