enable direct routing to the send page #15259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
darkwing
reviewed
Jul 15, 2022
| if ( | ||
| draftTransactionExists === false || | ||
| stage === SEND_STAGES.ADD_RECIPIENT || | ||
| stage === SEND_STAGES.INACTIVE |
Contributor
There was a problem hiding this comment.
Since you used .includes on line https://github.com/MetaMask/metamask-extension/pull/15259/files#diff-5fd11e9ad27369ac2d1e53fc158bc9fd26efaf0b9224509843ce70d141bd13bfR97, do you want to use it here?
Contributor
Author
There was a problem hiding this comment.
Yup, good call out. Done in latest
darkwing
reviewed
Jul 15, 2022
| // Ensure that the send flow renders on the add recipient screen when | ||
| // there is no draft transaction. | ||
| expect( | ||
| getByPlaceholderText('Search, public address (0x), or ENS'), |
Contributor
There was a problem hiding this comment.
I know we use this in another place but selecting elements by placeholder always feels kinda weird.
Contributor
Author
There was a problem hiding this comment.
why? This is a common way user's navigate forms... often times the placeholder text in inputs is more prominent or easier to reason about than the labels or the placeholder itself is the label.
Contributor
There was a problem hiding this comment.
Probably just because I think of selecting elements by CSS paradigms, and you usually wouldn't select an element like this. It's fine, just breaks my brain a little.
Contributor
Author
There was a problem hiding this comment.
The testing paradigm we should strive to emulate is one where we test our code how users interact with it. Instead of testing to see if internal values of a Counter class change when its addOne method is called, we should test that the on screen count increments when the user clicks the 'Add One' Button.
Collaborator
Builds ready [96f44f0]Page Load Metrics (1862 ± 57 ms)
highlights:storybook
|
adonesky1
approved these changes
Jul 18, 2022
Contributor
adonesky1
left a comment
adonesky1
left a comment
There was a problem hiding this comment.
LGTM! Code looks good, and QA'd testing steps and issues linked
darkwing
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When we refactored to not use global state for transaction data in the send flow, we made it a requirement to start a new draft transaction PRIOR to entering the send flow. This change allows us to gracefully handle situations that are edge cases such as when routing to the send screen directly, or if the user is in full screen mode and clicks back after moving to the confirm screen. Also added a test to cover this scenario.
More Information
Fixes #15188 #15183
Manual Testing Steps
Pre-Merge Checklist
+ If there are functional changes: