Skip to content

Conversation

@adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Jul 20, 2022

Due to a small bug in the getTitleTokenDescription function on confirm-approve-content.component.js we are not currently showing the symbol instead assetName on the setApprovalForAll confirmation screen, even when the latter is available and should be preferred.

Before:
Screen Shot 2022-07-20 at 10 15 16 AM

After:
Screen Shot 2022-07-20 at 10 12 48 AM

@adonesky1 adonesky1 requested a review from a team as a code owner July 20, 2022 15:15
@adonesky1 adonesky1 requested a review from hmalik88 July 20, 2022 15:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 merged commit 78b3215 into develop Jul 20, 2022
@adonesky1 adonesky1 deleted the tweak-set-approval-for-all-confirmation branch July 20, 2022 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [76cf42f]
Page Load Metrics (1846 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861911122512
domContentLoaded1693205318337737
load1693205318468139
domInteractive1693205318337737

highlights:

storybook

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants