Skip to content

Conversation

@bowensanders
Copy link
Contributor

Changes need to be made in order to make existing e2e tests work with the new test-snaps UI (see MetaMask/test-snaps#40)
This fixes both navigating through the pages as well as changes necessary to the refactor of class & id tags.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bowensanders bowensanders dismissed a stale review via a3bd87d June 22, 2022 02:32
@bowensanders
Copy link
Contributor Author

bowensanders commented Jun 23, 2022

These test are now working with, and can be co-deployed with MetaMask/test-snaps#40

However it cannot be merged until MetaMask/test-snaps#40 is merged because it refactors classes to id's

Also, MetaMask/test-snaps#40 breaks the current e2e's so they have to hit at the same time 😅

@bowensanders bowensanders marked this pull request as ready for review June 23, 2022 16:26
@bowensanders bowensanders requested a review from a team as a code owner June 23, 2022 16:26
@bowensanders bowensanders requested a review from adonesky1 June 23, 2022 16:26
@metamaskbot
Copy link
Collaborator

Builds ready [66f6640]
Page Load Metrics (1650 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8111495115
domContentLoaded1571172916294220
load1571180416505828
domInteractive1571172816294220

@bowensanders bowensanders self-assigned this Jul 6, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [18b2393]
Page Load Metrics (1857 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922027211417200
domContentLoaded16692189184212861
load16692209185713263
domInteractive16692189184212861

@bowensanders bowensanders merged commit b486524 into develop Jul 6, 2022
@bowensanders bowensanders deleted the snaps-e2e-upgrades branch July 6, 2022 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants