Skip to content

Snaps E2E Test Upgrades for the new test-snaps UI #14980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 6, 2022
Merged

Snaps E2E Test Upgrades for the new test-snaps UI #14980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a3bd87d
fixed e2e tests for new UI
bowensanders Jun 17, 2022
b888b53
Merge branch 'develop' of https://github.com/metamask/metamask-extens…
bowensanders Jun 23, 2022
ab68bf7
fixed scrolling in tests to be bi-compatible
bowensanders Jun 23, 2022
268118e
bringing up to date
bowensanders Jun 24, 2022
691649d
Merge branch 'develop' of https://github.com/metamask/metamask-extens…
bowensanders Jun 28, 2022
26daa0f
staging enums
bowensanders Jul 4, 2022
39cdd13
Merge branch 'develop' of https://github.com/metamask/metamask-extens…
bowensanders Jul 4, 2022
66f6640
updated enums to reflect new UI version
bowensanders Jul 5, 2022
18b2393
requested changes
bowensanders Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/snaps/enums.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
TEST_SNAPS_WEBSITE_URL: 'https://metamask.github.io/test-snaps/1.0.0',
TEST_SNAPS_WEBSITE_URL: 'https://metamask.github.io/test-snaps/2.0.0',
};
22 changes: 12 additions & 10 deletions test/e2e/snaps/test-snap-bip-44.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,16 @@ describe('Test Snap bip-44', function () {

// navigate to test snaps page and connect
await driver.driver.get(TEST_SNAPS_WEBSITE_URL);
await driver.fill('.snapId3', 'npm:@metamask/test-snap-bip44');
await driver.clickElement({
text: 'Connect BIP-44 Snap',
tag: 'button',
});
await driver.delay(1000);
await driver.fill('#snapId3', 'npm:@metamask/test-snap-bip44');

// reveal snapId3 by finding and scrolling to #snapId4
const snapButton = await driver.findElement('#snapId4');
await driver.scrollToElement(snapButton);
await driver.delay(500);

// connect the snap
await driver.clickElement('#connectBip44');

// switch to metamask extension and click connect
await driver.waitUntilXWindowHandles(2, 5000, 10000);
Expand Down Expand Up @@ -77,14 +82,11 @@ describe('Test Snap bip-44', function () {
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement({
text: 'Send Test to BIP-44 Snap',
tag: 'button',
});
await driver.clickElement('#sendBip44');

// check the results of the public key test
await driver.delay(2000);
const bip44Result = await driver.findElement('.bip44Result');
const bip44Result = await driver.findElement('#bip44Result');
assert.equal(
await bip44Result.getText(),
'Public key: "0x86debb44fb3a984d93f326131d4c1db0bc39644f1a67b673b3ab45941a1cea6a385981755185ac4594b6521e4d1e8d1"',
Expand Down
11 changes: 4 additions & 7 deletions test/e2e/snaps/test-snap-confirm.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,8 @@ describe('Test Snap Confirm', function () {

// navigate to test snaps page and connect
await driver.driver.get(TEST_SNAPS_WEBSITE_URL);
await driver.fill('.snapId1', 'npm:@metamask/test-snap-confirm');
await driver.clickElement({
text: 'Connect To Confirm Snap',
tag: 'button',
});
await driver.fill('#snapId1', 'npm:@metamask/test-snap-confirm');
await driver.clickElement('#connectHello');

// switch to metamask extension and click connect
await driver.waitUntilXWindowHandles(2, 5000, 10000);
Expand Down Expand Up @@ -70,7 +67,7 @@ describe('Test Snap Confirm', function () {
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement('.sendConfirmButton');
await driver.clickElement('#sendConfirmButton');

// hit 'approve' on the custom confirm
await driver.waitUntilXWindowHandles(2, 5000, 10000);
Expand All @@ -88,7 +85,7 @@ describe('Test Snap Confirm', function () {
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
const confirmResult = await driver.findElement('.confirmResult');
const confirmResult = await driver.findElement('#confirmResult');
assert.equal(await confirmResult.getText(), 'true');
},
);
Expand Down
12 changes: 3 additions & 9 deletions test/e2e/snaps/test-snap-error.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,8 @@ describe('Test Snap Error', function () {

// navigate to test snaps page and connect
await driver.driver.get(TEST_SNAPS_WEBSITE_URL);
await driver.fill('.snapId2', 'npm:@metamask/test-snap-error');
await driver.clickElement({
text: 'Connect Error Snap',
tag: 'button',
});
await driver.fill('#snapId2', 'npm:@metamask/test-snap-error');
await driver.clickElement('#connectError');

// switch to metamask extension and click connect
await driver.waitUntilXWindowHandles(2, 5000, 10000);
Expand Down Expand Up @@ -68,10 +65,7 @@ describe('Test Snap Error', function () {
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement({
text: 'Send Test to Error Snap',
tag: 'button',
});
await driver.clickElement('#sendError');

await driver.navigate(PAGES.HOME);

Expand Down
66 changes: 25 additions & 41 deletions test/e2e/snaps/test-snap-managestate.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ describe('Test Snap manageState', function () {
},
],
};

await withFixtures(
{
fixtures: 'imported-account',
Expand All @@ -29,13 +30,18 @@ describe('Test Snap manageState', function () {
await driver.fill('#password', 'correct horse battery staple');
await driver.press('#password', driver.Key.ENTER);

// navigate to test snaps page and connect
// navigate to test snaps page, then fill in the snapId
await driver.driver.get(TEST_SNAPS_WEBSITE_URL);
await driver.fill('.snapId3', 'npm:@metamask/test-snap-managestate');
await driver.clickElement({
text: 'Connect manageState Snap',
tag: 'button',
});
await driver.delay(1000);
await driver.fill('#snapId4', 'npm:@metamask/test-snap-managestate');

// find and scroll to the rest of the card
const snapButton = await driver.findElement('#snapId4');
await driver.scrollToElement(snapButton);
await driver.delay(500);

// connect the snap
await driver.clickElement('#connectManageState');

// switch to metamask extension and click connect
await driver.waitUntilXWindowHandles(2, 5000, 10000);
Expand All @@ -51,7 +57,6 @@ describe('Test Snap manageState', function () {
},
10000,
);

await driver.delay(2000);

// approve install of snap
Expand All @@ -70,67 +75,46 @@ describe('Test Snap manageState', function () {
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.fill('.dataManageState', '23');
await driver.clickElement({
text: 'Send data to manageState Snap',
tag: 'button',
});
await driver.fill('#dataManageState', '23');
await driver.clickElement('#sendManageState');

// check the results of the public key test
await driver.delay(2000);
await driver.delay(500);
const manageStateResult = await driver.findElement(
'.sendManageStateResult',
'#sendManageStateResult',
);
assert.equal(await manageStateResult.getText(), 'true');

// click get results
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement({
text: 'Get data from manageState Snap',
tag: 'button',
});
await driver.clickElement('#retrieveManageState');

// check the results
await driver.delay(2000);
await driver.delay(500);
const retrieveManageStateResult = await driver.findElement(
'.retrieveManageStateResult',
'#retrieveManageStateResult',
);
assert.equal(
await retrieveManageStateResult.getText(),
'{"testState":["23"]}',
);

// click clear results
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement({
text: 'Clear data of manageState Snap',
tag: 'button',
});
await driver.clickElement('#clearManageState');

// check if true
await driver.delay(2000);
await driver.delay(500);
const clearManageStateResult = await driver.findElement(
'.clearManageStateResult',
'#clearManageStateResult',
);
assert.equal(await clearManageStateResult.getText(), 'true');

// click get results again
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement({
text: 'Get data from manageState Snap',
tag: 'button',
});
await driver.clickElement('#retrieveManageState');

// check result array is empty
await driver.delay(2000);
await driver.delay(500);
const retrieveManageStateResult2 = await driver.findElement(
'.retrieveManageStateResult',
'#retrieveManageStateResult',
);
assert.equal(
await retrieveManageStateResult2.getText(),
Expand Down
22 changes: 12 additions & 10 deletions test/e2e/snaps/test-snap-notification.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ describe('Test Snap Notification', function () {
await driver.fill('#password', 'correct horse battery staple');
await driver.press('#password', driver.Key.ENTER);

// navigate to test snaps page and connect
// navigate to test snaps page
await driver.driver.get(TEST_SNAPS_WEBSITE_URL);
await driver.fill('.snapId5', 'npm:@metamask/test-snap-notification');
await driver.clickElement({
text: 'Connect Notification Snap',
tag: 'button',
});
await driver.delay(1000);

// find and scroll down to snapId5
const snapButton = await driver.findElement('#snapId5');
await driver.scrollToElement(snapButton);
await driver.delay(500);
await driver.fill('#snapId5', 'npm:@metamask/test-snap-notification');

// connect the snap
await driver.clickElement('#connectNotification');

// switch to metamask extension and click connect
await driver.waitUntilXWindowHandles(2, 5000, 10000);
Expand Down Expand Up @@ -70,10 +75,7 @@ describe('Test Snap Notification', function () {
await driver.waitUntilXWindowHandles(1, 5000, 10000);
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('Test Snaps', windowHandles);
await driver.clickElement({
text: 'Send InApp Notification',
tag: 'button',
});
await driver.clickElement('#sendInAppNotification');

// try to go to the MM pages
await driver.navigate(PAGES.HOME);
Expand Down