Skip to content

Improve confirm screen tests #15163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2022
Merged

Improve confirm screen tests #15163

merged 4 commits into from
Jul 12, 2022

Conversation

@danjm
Copy link
Contributor

@danjm danjm commented Jul 8, 2022

This makes our tests around displayed recipients on the confirm screen more robust.

@danjm danjm requested a review from a team as a code owner July 8, 2022 13:55
@danjm danjm requested a review from brad-decker July 8, 2022 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Anastasia1510
Anastasia1510 previously approved these changes Jul 9, 2022
View reviewed changes
@darkwing
Copy link
Contributor

darkwing commented Jul 11, 2022

Is this test failure legit?

@danjm danjm dismissed stale reviews from Anastasia1510 and ghost via 21be983 July 11, 2022 19:07
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jul 11, 2022

Builds ready [21be983]
Page Load Metrics (1709 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861801122110
domContentLoaded1607194817017636
load1607194817097536
domInteractive1607194817017637

highlights:

storybook

@danjm
Copy link
Contributor Author

danjm commented Jul 12, 2022

@seaona can you share the repro steps for how the wrong address is still shown when going through the in-app send flow? I can't repro

@danjm danjm force-pushed the improve-confirm-screen-tests branch from 21be983 to 8066ffb Compare July 12, 2022 00:06
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jul 12, 2022

Builds ready [8066ffb]
Page Load Metrics (1805 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint931840217376181
domContentLoaded159523461794207100
load15952346180520598
domInteractive159523461794207100

highlights:

storybook

@seaona
Copy link
Member

seaona commented Jul 12, 2022

@danjm tried again and it's working fine in my end! QA pass

ryanml
ryanml approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@danjm danjm merged commit f785f77 into develop Jul 12, 2022
@danjm danjm deleted the improve-confirm-screen-tests branch July 12, 2022 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@brad-decker brad-decker brad-decker approved these changes

@ryanml ryanml ryanml approved these changes

@Anastasia1510 Anastasia1510 Anastasia1510 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@danjm @darkwing @metamaskbot @seaona @brad-decker @ryanml @Anastasia1510