Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 1, 2022

This PR bumps the minimum Node.js version of the extension to ^16. I had to change a couple of expected error messages in tests, but otherwise everything appears to work out of the box.

The motivations for this are as follows:

  • The Snaps team is facing some issues with Node 14 in our monorepo, and rather than hacking our way to a solution we'd rather abandon Node 14.
  • We have to do this in less than a year anyway, due to the Node.js LTS schedule.
  • Node 16 is probably a little bit faster than 14, so everybody wins when we do this.

@metamaskbot
Copy link
Collaborator

Builds ready [7a0e974]
Page Load Metrics (1656 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8213997136
domContentLoaded1529181716387033
load1564183416567134
domInteractive1529181716387033

@rekmarks rekmarks marked this pull request as ready for review July 1, 2022 20:57
@rekmarks rekmarks requested review from a team and kumavis as code owners July 1, 2022 20:57
@rekmarks rekmarks requested a review from danjm July 1, 2022 20:57
@metamaskbot
Copy link
Collaborator

Builds ready [cf0e1c3]
Page Load Metrics (1614 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81177982010
domContentLoaded1522170915985326
load1522176916146933
domInteractive1522170915985326

@rekmarks rekmarks merged commit 08cc6c5 into develop Jul 3, 2022
@rekmarks rekmarks deleted the node-16 branch July 3, 2022 06:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants