Bump minimum Node.js version to 16 (#15131)

Author: rekmarks

.circleci/config.yml

@@ -3,10 +3,10 @@ version: 2.1
 executors:
   node-browsers:
     docker:
-      - image: circleci/node:14-browsers
+      - image: circleci/node:16-browsers
   node-browsers-medium-plus:
     docker:
-      - image: circleci/node:14-browsers
+      - image: circleci/node:16-browsers
     resource_class: medium+
     environment:
       NODE_OPTIONS: --max_old_space_size=2048

.nvmrc

@@ -1 +1 @@
-v14
+v16

app/scripts/lib/ComposableObservableStore.test.js

@@ -165,7 +165,7 @@ describe('ComposableObservableStore', () => {
             Example: exampleController,
           },
         }),
-    ).toThrow(`Cannot read property 'subscribe' of undefined`);
+    ).toThrow(`Cannot read properties of undefined (reading 'subscribe')`);
   });
 
   it('should throw if the controller messenger is omitted and updateStructure called with a BaseControllerV2 controller', () => {
@@ -175,7 +175,7 @@ describe('ComposableObservableStore', () => {
     });
     const store = new ComposableObservableStore({});
     expect(() => store.updateStructure({ Example: exampleController })).toThrow(
-      `Cannot read property 'subscribe' of undefined`,
+      `Cannot read properties of undefined (reading 'subscribe')`,
     );
   });
 

development/build/transforms/utils.test.js

@@ -26,7 +26,7 @@ describe('transform utils', () => {
       // This error is an artifact of how we're mocking the ESLint singleton,
       // and won't actually occur in production.
       await expect(() => lintTransformedFile()).rejects.toThrow(
-        `Cannot read property '0' of undefined`,
+        `Cannot read properties of undefined (reading '0')`,
       );
       expect(mockESLint).toBeDefined();
     });

package.json

@@ -381,7 +381,7 @@
     "yarn-deduplicate": "^3.1.0"
   },
   "engines": {
-    "node": "^14.15.1",
+    "node": "^16.0.0",
     "yarn": "^1.16.0"
   },
   "lavamoat": {