Skip to content

Update Optimism ChainID from Kovan to Goerli #15119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2022
Merged

Update Optimism ChainID from Kovan to Goerli #15119

merged 1 commit into from
Jul 2, 2022

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 1, 2022

This is a reimplementation of #15115 - pointed correctly at develop

@ryanml ryanml requested a review from a team as a code owner July 1, 2022 01:36
@ryanml ryanml self-assigned this Jul 1, 2022
@ryanml ryanml requested a review from hmalik88 July 1, 2022 01:36
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jul 1, 2022

Builds ready [1523ed4]
Page Load Metrics (1750 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811781142110
domContentLoaded15872118173413665
load15872233175015172
domInteractive15872118173413665

highlights:

storybook

@ryanml ryanml merged commit 7ee492b into develop Jul 2, 2022
@ryanml ryanml deleted the 15115-redo branch July 2, 2022 02:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis kumavis approved these changes

@hmalik88 hmalik88 Awaiting requested review from hmalik88 hmalik88 is a code owner automatically assigned from MetaMask/extension-devs

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ryanml ryanml

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ryanml @metamaskbot @kumavis @danjm