Skip to content

Revert v10.16.0 #15063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Revert v10.16.0 #15063

merged 1 commit into from
Jun 28, 2022
+6,400 −11,493

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 28, 2022

This reverts commit f09ab88, reversing changes made to effc761.

This is being temporarily reverted to make it easier to release an urgent fix for v10.15.1.

@Gudahtt
Revert "Merge pull request #14912 from MetaMask/Version-v10.16.0"
925a19f 
This reverts commit f09ab88, reversing
changes made to effc761.

This is being temporarily reverted to make it easier to release an
urgent fix for v10.15.1.
@Gudahtt Gudahtt marked this pull request as ready for review June 28, 2022 13:14
@Gudahtt Gudahtt requested review from a team and kumavis as code owners June 28, 2022 13:14
@Gudahtt Gudahtt requested a review from segun June 28, 2022 13:14
@danjm
Copy link
Contributor

danjm commented Jun 28, 2022

line additions and deletions are opposite to #14912, so this should be correct

@danjm danjm mentioned this pull request Jun 28, 2022
Merged
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 28, 2022

Builds ready [925a19f]
Page Load Metrics (1838 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81152103178
domContentLoaded16102106182113163
load16102106183812761
domInteractive16102106182113163

highlights:

storybook

@danjm danjm merged commit 4d42715 into master Jun 28, 2022
@danjm danjm deleted the revert-v10.16.0 branch June 28, 2022 14:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@segun segun Awaiting requested review from segun segun was automatically assigned from MetaMask/extension-devs

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gudahtt @danjm @metamaskbot @adonesky1