Skip to content

Conversation

@metamaskbot
Copy link
Collaborator

📦 🚀

shanejonas and others added 30 commits April 29, 2022 06:05
* Added getAccounts suppressUnauthorized param

* Changed getAccounts supresss unauth param name

* Changed getAccounts param to object

* Fixed default empty obj for getAccounts getPermittedAccounts param

* Bump eth-json-rpc-middleware version to 8.0.2

* Fixed lavamoat policy

* Fixed lavamoat policies

* Fixed dedupe issues

* Fixed lavamoat allowscripts

* yarn deduplicate

* Fixed lavamoat policies

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
* update to expect promise from browser api polyfill rather than pass callback
Adds a new flag, `--apply-lavamoat`, to the main build script. The flag controls whether LavaMoat is actually applied to the output of the build process. The flag defaults to `true`, but we explicitly set it to `false` in the `start` package script. Meanwhile, the `start:lavamoat` script is modified such that it applies LavaMoat to the build output in development mode, but it no longer runs the build process itself under LavaMoat as there aren't very compelling reasons to do so.

This change is motivated by the fact that development builds do not have their own dedicated LavaMoat policies, which causes development builds to fail since #14537. The downside of this change is that LavaMoat-related failures will not be detected when running `yarn start`. @kumavis has plans for fixing this problem in a future major version of the `@lavamoat` suite.
#14583 broke the development build scripts (e.g. `yarn start`) by adding a positional argument to a package script (`build:dev`) that is used and passed positional arguments in the build script itself. This PR removes the positional argument from the `build:dev` script and `yarn start` now works again. In addition, the `--apply-lavamoat` flag is properly forwarded to child processes, which was not the case in the original implementation.

To test, `yarn start` should work and LavaMoat should _not_ be applied, in distinction to `yarn build:dev dev --apply-lavamoat=true`. Whether LavaMoat is applied can be determined by checking whether `Object.isFrozen(Object.prototype)` is `true` (with LavaMoat) or `false` (without LavaMoat).
* Disable STX if a regular tx is in progress

* disableStxIfRegularTxInProgress : early return

* Fix UTs

* Trigger Build
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
* Update version parsing to allow rollback release

When we want to rollback a release on Chrome, sometimes we use the
fourth part of the version for the rollback release. This is because
the Chrome web stores does not directly allow rolling back, but instead
requires us to re-submit the release we want to roll back to with a
higher version number.

The manifest version parsing now allows for a fourth version part.

The comments have also been updated to be more descriptive, and to fix
a minor inaccuracy.

* Fix typo in comment

Co-authored-by: David Walsh <davidwalsh83@gmail.com>

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
* add jest-it-up dependancy

* add reporter

* post test run jest-it-up

* Add CI check

* update coverage

* deduplicate dependancies
The lockfile would change upon install due to a redundant entry. This
seems to have been introduced in #14612 as a result of running
`yarn-deduplicate`.
* Create `.zip` files deterministically

Our build system now creates `.zip` archives deterministically.
Previously the `.zip` file would differ between builds even when the
files being archived were identical. This was because the order the
files were passed in was non-deterministic, and the `mtime` for each
file was different between builds.

The files are now sorted before being zipped, and the `mtime` for each
file has been set to the unix epoch.

* Update lavamoat build policy
…14467)

GridPlus has updated the EVM signing pathway in Lattice firmware,
which has not yet been released. Additionally, requesters can now
include ABI definitions with signing requests, which are used by
Lattice firmware to decode calldata in place.
All updates are backward compatable.
Updates:
* GridPlus/gridplus-sdk@v1.1.6...v1.2.4
* GridPlus/eth-lattice-keyring@v0.6.1...v0.7.3
* update fill method

* remove redundant steps

* remove arbitrary delays
* lavamoat - update lavamoat-browserify to v15

* lavamoat/ui - unify override across build types

* lavamoat/ui - update policy overrides

* lavamoat - update to lavapack@3 to match lavamoat-browserify@15

* lavamoat - add missing policy

* lavamoat - add missing nanoid policy

* lavamoat - regenerate policy

* deps - update lock

* lavamoat - update policy

* lavamoat - update policy
* Fix SRP paste duplication

* Remove else-case for paste event

* Add E2E test that would catch this issue in the future

* Fix linting
* Fixing Speed up/Cancel information text

* Adding tests
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ryanml ryanml dismissed a stale review via 80e7d82 June 16, 2022 16:44
@danjm
Copy link
Contributor

danjm commented Jun 20, 2022

Let's add this commit #14972

@ryanml @danjm

@danjm
Copy link
Contributor

danjm commented Jun 20, 2022

We need this commit to fix the e2e tests #14939

@danjm
Copy link
Contributor

danjm commented Jun 20, 2022

Need to fix lavamoat config
@danjm

@seaona
Copy link
Member

seaona commented Jun 20, 2022

Need to fix lavamoat config @danjm

lavamoat fixed 👍

FrederikBolding and others added 2 commits June 20, 2022 17:53
* Update xDAI E2E information

* Use local Ganache instance instead of Gnosis Chain

* Bump test-dapp

* Bump test-dapp

* Enable secondary Ganache server for other test

* Fix linting

* Improve E2E stability

* Update network selector
* Only have timeout for when payload is getState

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Fix test

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@ryanml
Copy link
Contributor

ryanml commented Jun 21, 2022

@danjm @seaona #14972 and #14939 have been added to the RC

seaona and others added 7 commits June 23, 2022 04:12
* Changelog for 10.16.0 cleaned up

* Updates for fixing PR review comments

* Remove bug fix for a bug that never made it to prod

* Re-phrased fix permissions to fix currency symbol

* Update with review comment fixes and add Snaps uncategorized PRs

* Reorg

* Apply suggestions from code review - Snaps

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Categorized snaps PRs under correct type

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
…MethodData` (#14937)

* Increase likelyhood of valid method signatures being returned by getMethodData

* Update coverage

* Update coverage

* Update coverage

* add a migration to clear knownMethodData

* Small typo changes

Co-authored-by: Alex <adonesky@gmail.com>
@metamaskbot
Copy link
Collaborator Author

Builds ready [de228da]
Page Load Metrics (2409 ± 137 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1052485397687330
domContentLoaded185228222381278133
load187928222409286137
domInteractive185228222380278133

highlights:

storybook

@ryanml ryanml marked this pull request as ready for review June 23, 2022 16:36
@ryanml ryanml requested review from a team and kumavis as code owners June 23, 2022 16:36
@ryanml ryanml requested a review from PeterYinusa June 23, 2022 16:36
@danjm danjm merged commit f09ab88 into master Jun 23, 2022
@danjm danjm deleted the Version-v10.16.0 branch June 23, 2022 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.