Update version parsing to allow rollback release #14288
Merged
+18
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we want to rollback a release on Chrome, sometimes we use the fourth part of the version for the rollback release. This is because the Chrome web stores does not directly allow rolling back, but instead requires us to re-submit the release we want to roll back to with a higher version number. The manifest version parsing now allows for a fourth version part. The comments have also been updated to be more descriptive, and to fix a minor inaccuracy.
Gudahtt
force-pushed
the
update-version-parsing-to-allow-rollback-release
branch
from
555bc31 to
7b66187
Compare
Collaborator
Builds ready [7b66187]Page Load Metrics (1324 ± 62 ms)
|
ryanml
previously approved these changes
Mar 31, 2022
darkwing
suggested changes
Apr 4, 2022
Contributor
darkwing
left a comment
darkwing
left a comment
There was a problem hiding this comment.
Tiniest, most infuriating nit ever.
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Collaborator
Builds ready [2ac8d3e]Page Load Metrics (1255 ± 37 ms)
|
darkwing
approved these changes
Apr 6, 2022
brad-decker
approved these changes
May 3, 2022
Contributor
brad-decker
left a comment
brad-decker
left a comment
There was a problem hiding this comment.
LGTM. Tested locally as well.
Collaborator
Builds ready [e4bc689]Page Load Metrics (1675 ± 30 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When we want to rollback a release on Chrome, sometimes we use the fourth part of the version for the rollback release. This is because the Chrome web stores does not directly allow rolling back, but instead requires us to re-submit the release we want to roll back to with a higher version number.
The manifest version parsing now allows for a fourth version part.
The comments have also been updated to be more descriptive, and to fix a minor inaccuracy.
Manual testing steps
package.json(e.g. "v10.12.2.1").