Skip to content

Conversation

@alex-miller-0
Copy link
Contributor

@alex-miller-0 alex-miller-0 commented Apr 18, 2022

GridPlus has updated the EVM signing pathway in Lattice firmware,
which has not yet been released. Additionally, requesters can now
include ABI definitions with signing requests, which are used by
Lattice firmware to decode calldata in place.
All updates are backward compatable.
Updates:

@alex-miller-0 alex-miller-0 requested a review from a team as a code owner April 18, 2022 21:35
@alex-miller-0 alex-miller-0 requested a review from digiwand April 18, 2022 21:35
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand
Copy link
Contributor

digiwand commented Apr 19, 2022

Comparing:
GridPlus/eth-lattice-keyring@v0.6.1...v0.7.1
&
GridPlus/gridplus-sdk@v1.1.6...v1.2.0

[edit] outdated. Refer to compare links in description

digiwand
digiwand previously approved these changes Apr 19, 2022
danjm
danjm previously approved these changes Apr 26, 2022
GridPlus has updated the EVM signing pathway in Lattice firmware,
which has not yet been released. Additionally, requesters can now
include ABI definitions with signing requests, which are used by
Lattice firmware to decode calldata in place.
All updates are backward compatable.
Updates:
* GridPlus/gridplus-sdk@v1.1.6...v1.2.4
* GridPlus/eth-lattice-keyring@v0.6.1...v0.7.3
@alex-miller-0 alex-miller-0 changed the title [GridPlus] Bumps eth-lattice-keyring to enable future ETH signing p… [GridPlus] Update modules to unlock future Lattice functionality May 3, 2022
@alex-miller-0
Copy link
Contributor Author

@danjm @digiwand I updated this branch to include the latest changes. Relative to the previous review these are very minor changes. I also rebased off of metamask/develop after running lavamoat:auto, so the changes in this PR are now isolated to GridPlus. We tested without the develop-based lavamoat run and saw no difference in functionality.

@alex-miller-0 alex-miller-0 requested review from danjm and digiwand May 3, 2022 19:28
@digiwand digiwand merged commit 32a82be into MetaMask:develop May 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
@alex-miller-0 alex-miller-0 deleted the lattice branch May 5, 2022 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants