Skip to content

Conversation

@brad-decker
Copy link
Contributor

Explanation

yarn-audit is failing due to vulnerability: https://github.com/MetaMask/metamask-extension/security/dependabot/66 in cross-fetch. This PR sets a resolution for cross-fetch to 3.1.5 or higher

@brad-decker brad-decker requested a review from a team as a code owner April 29, 2022 15:27
@brad-decker brad-decker requested a review from segun April 29, 2022 15:27
@metamaskbot
Copy link
Collaborator

Builds ready [529e84e]
Page Load Metrics (1779 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint801708177351169
domContentLoaded1639199717529144
load16391997177910651
domInteractive1639199717529144

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GuillaumeRx GuillaumeRx merged commit 54a89f0 into develop Apr 29, 2022
@GuillaumeRx GuillaumeRx deleted the fix-cross-fetch-vuln branch April 29, 2022 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants