Skip to content

Conversation

@adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented May 4, 2022

Currently we are not fetching USD conversion rates when user's preferred secondary currency is not USD as we intend to because the CurrencyRateController expects option to be cased as includeUsdRate and we are passing incorrectly cased includeUSDRate

@adonesky1 adonesky1 requested a review from a team as a code owner May 4, 2022 17:04
@adonesky1 adonesky1 requested a review from Gtonizuka May 4, 2022 17:04
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 requested review from dan437 and danjm May 4, 2022 17:09
@metamaskbot
Copy link
Collaborator

Builds ready [e0553f3]
Page Load Metrics (1741 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85143104157
domContentLoaded15902005172710149
load1600202317419847
domInteractive15902005172710148

@dan437 dan437 merged commit 4550a10 into develop May 5, 2022
@dan437 dan437 deleted the fix-missing-usd-conversion branch May 5, 2022 14:14
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants