util - lazy instantiate ec for init perf boost #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-miller-0
approved these changes
Apr 29, 2022
Merged
rekmarks
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 29, 2022
short-term fix for GridPlus/gridplus-sdk#367
acria-dominik
pushed a commit
to acria-dominik/acriawallet-extension
that referenced
this pull request
Oct 13, 2022
short-term fix for GridPlus/gridplus-sdk#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the browser with 🌋 LavaMoat 🌋 , module initialization times went 4150ms -> 86ms for this module when this change was made
the 4s initialization of this module is by far the largest in metamask background context
i believe the underlying performance issue comes from a bug in v8 where there is a large slowdown when setting a field on an instance of a TypedArray subclass that has been
Object.freeze'd as in SES lockdown as employed in 🌋 LavaMoat 🌋cheers ✌️