Skip to content

Conversation

@kumavis
Copy link
Member

@kumavis kumavis commented Apr 29, 2022

short-term fix for GridPlus/gridplus-sdk#367

@kumavis kumavis requested a review from a team as a code owner April 29, 2022 18:19
@kumavis kumavis requested a review from darkwing April 29, 2022 18:19
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship iiiitttttt

@metamaskbot
Copy link
Collaborator

Builds ready [5687c39]
Page Load Metrics (1710 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint77145104199
domContentLoaded1597182916856330
load1603188617107034
domInteractive1597182916856330

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@rekmarks rekmarks merged commit a746997 into develop Apr 29, 2022
@rekmarks rekmarks deleted the patch-gridplus-init-perf branch April 29, 2022 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
@kumavis
Copy link
Member Author

kumavis commented May 3, 2022

patch also shipped in sdk update GridPlus/gridplus-sdk#373 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants