Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 5, 2022

Explanation

Fixed an issue where pasting a Secret Recovery Phrase word by word would paste the words duplicated.

More Information

Fixes #14620

Manual Testing Steps

  • Go to vault creation page
  • Paste a Secret Recovery Phrase word by word
  • See that none of the words are duplicated
  • Paste a Secret Recovery Phrase all at once
  • See that it also works!

Pre-Merge Checklist

  • PR template is filled out
  • Manual testing complete & passed
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • IF QA attention is required, "QA Board" label has been applied
  • PR has been added to the appropriate release Milestone

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 5, 2022 13:02
@FrederikBolding FrederikBolding requested a review from jpuri May 5, 2022 13:02
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@FrederikBolding FrederikBolding requested a review from Gudahtt May 5, 2022 13:15
@metamaskbot
Copy link
Collaborator

Builds ready [9fa9cfb]
Page Load Metrics (1723 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint792981114622
domContentLoaded1561183417067938
load1623185017236732
domInteractive1561183317067938

highlights:

storybook

darkwing
darkwing previously approved these changes May 5, 2022
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing steps worked great! Good job!

It would be a new task obviously but we should consider adding a clear form type of functionality in the future.

@metamaskbot
Copy link
Collaborator

Builds ready [cb60310]
Page Load Metrics (1764 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint791901042411
domContentLoaded16342039174610450
load16492062176410249
domInteractive16342039174610450

highlights:

storybook

@Gudahtt Gudahtt added the needs-qa Label will automate into QA workspace label May 9, 2022
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@FrederikBolding FrederikBolding merged commit fa9d703 into develop May 9, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-srp-paste-duplication branch May 9, 2022 12:46
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-qa Label will automate into QA workspace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Metamask doubling the word when copy-paste

5 participants