-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix development build scripts #14594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
previously approved these changes
May 2, 2022
brad-decker
previously approved these changes
May 2, 2022
Contributor
|
Tested by running |
dan437
approved these changes
May 2, 2022
Contributor
dan437
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, yarn start works now and there is no white screen after opening the extension. Thank you!
25761ff to
25d6583
Compare
Contributor
brad-decker
approved these changes
May 2, 2022
Collaborator
Builds ready [25d6583]Page Load Metrics (1809 ± 41 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14583 broke the development build scripts (e.g.
yarn start) by adding a positional argument to a package script (build:dev) that is used and passed positional arguments in the build script itself. This PR removes the positional argument from thebuild:devscript andyarn startnow works again. In addition, the--apply-lavamoatflag is properly forwarded to child processes, which was not the case in the original implementation.To test,
yarn startshould work and LavaMoat should not be applied, in distinction toyarn build:dev dev --apply-lavamoat=true. Whether LavaMoat is applied can be determined by checking whetherObject.isFrozen(Object.prototype)istrue(with LavaMoat) orfalse(without LavaMoat).