Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented May 2, 2022

#14583 broke the development build scripts (e.g. yarn start) by adding a positional argument to a package script (build:dev) that is used and passed positional arguments in the build script itself. This PR removes the positional argument from the build:dev script and yarn start now works again. In addition, the --apply-lavamoat flag is properly forwarded to child processes, which was not the case in the original implementation.

To test, yarn start should work and LavaMoat should not be applied, in distinction to yarn build:dev dev --apply-lavamoat=true. Whether LavaMoat is applied can be determined by checking whether Object.isFrozen(Object.prototype) is true (with LavaMoat) or false (without LavaMoat).

@rekmarks rekmarks requested a review from a team as a code owner May 2, 2022 15:22
@rekmarks rekmarks requested a review from georgewrmarshall May 2, 2022 15:22
jpuri
jpuri previously approved these changes May 2, 2022
brad-decker
brad-decker previously approved these changes May 2, 2022
@jpuri
Copy link
Contributor

jpuri commented May 2, 2022

Tested by running yarn start locally and works well.

@rekmarks rekmarks dismissed stale reviews from brad-decker and jpuri via 25761ff May 2, 2022 18:02
@rekmarks rekmarks requested a review from kumavis as a code owner May 2, 2022 18:02
Copy link
Contributor

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, yarn start works now and there is no white screen after opening the extension. Thank you!

@rekmarks rekmarks requested review from brad-decker and jpuri May 2, 2022 18:59
@brad-decker brad-decker force-pushed the fix-build-scripts branch from 25761ff to 25d6583 Compare May 2, 2022 21:50
@brad-decker
Copy link
Contributor

@rekmarks @dan437 rebasing on develop now that the fix for the e2e test failure has landed

@rekmarks rekmarks merged commit 6915dd1 into develop May 2, 2022
@rekmarks rekmarks deleted the fix-build-scripts branch May 2, 2022 22:35
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [25d6583]
Page Load Metrics (1809 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871784196365175
domContentLoaded1618190417647034
load1646199818098541
domInteractive1618190417647034

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants