Skip to content

Conversation

@seaona
Copy link
Member

@seaona seaona commented Jun 14, 2022

Explanation

Curated changelog for 10.16.0

@seaona seaona requested a review from a team as a code owner June 14, 2022 17:51
@seaona seaona requested a review from digiwand June 14, 2022 17:51
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona changed the base branch from develop to Version-v10.16.0 June 14, 2022 17:51
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall! I have left a number of suggestions.

seaona and others added 2 commits June 21, 2022 16:53
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
- fix cross-fetch moderate vulnerability alert ([#14570](https://github.com/MetaMask/metamask-extension/pull/14570))
- Fix browser.tab.get call ([#14550](https://github.com/MetaMask/metamask-extension/pull/14550))
- Added getAccounts suppressUnauthorized param ([#14126](https://github.com/MetaMask/metamask-extension/pull/14126))
- **[FLASK]** Add in-app notifications for snaps ([#14605](https://github.com/MetaMask/metamask-extension/pull/14605))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "snap"/"snaps" something we want to capitalize? I've noticed this in a few translations where we capitalize Snaps. @FrederikBolding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question

however, this need not be a blocker for the changelog, and we can update this later, so I am going to merge before this question in resolved

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question @digiwand - I'll check with the team to get our shared opinion on it!

@danjm danjm merged commit f85806c into Version-v10.16.0 Jun 23, 2022
@danjm danjm deleted the update-v10.16.0-changelog branch June 23, 2022 06:42
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants