Skip to content

Simplify removeSnap functionality after snaps-skunkworks update #14646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

Simplify removeSnap functionality after snaps-skunkworks update #14646

merged 1 commit into from
May 9, 2022

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 9, 2022

Explanation

Simplified removeSnap after changes in snaps-skunkworks to add PermissionController:revokePermissionForAllSubjects. This was done in https://github.com/MetaMask/snaps-skunkworks/releases/tag/v0.11.0

Manual Testing Steps

  1. Connect and install https://filsnap.chainsafe.io/
  2. Go to settings -> snaps
  3. Remove the snap and see that it is removed successfully

Pre-Merge Checklist

  • PR template is filled out
  • Manual testing complete & passed
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • IF QA attention is required, "QA Board" label has been applied
  • PR has been added to the appropriate release Milestone

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 9, 2022 12:07
@FrederikBolding FrederikBolding requested a review from darkwing May 9, 2022 12:07
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@FrederikBolding FrederikBolding changed the title Simplify removeSnap functionality after snaps-skunkworks update Simplify removeSnap functionality after snaps-skunkworks update May 9, 2022
@GuillaumeRx GuillaumeRx self-requested a review May 9, 2022 12:44
@metamaskbot
Copy link
Collaborator

metamaskbot commented May 9, 2022

Builds ready [01bc48c]
Page Load Metrics (1636 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741687240459220
domContentLoaded1538189516167938
load1545189516368139
domInteractive1537189516167938

highlights:

storybook

@FrederikBolding FrederikBolding merged commit 9e401b1 into develop May 9, 2022
@FrederikBolding FrederikBolding deleted the fb/simplify-remove-snap branch May 9, 2022 16:19
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@darkwing darkwing Awaiting requested review from darkwing darkwing is a code owner automatically assigned from MetaMask/extension-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FrederikBolding @metamaskbot @jpuri @GuillaumeRx