Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jun 14, 2022

Explanation

Updates the wallet_addEthereumChain E2E test to use a local Ganache instance instead of outdated XDAI RPC.

More Information

To be merged with: MetaMask/test-dapp#174

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

Copy link
Contributor

@PeterYinusa PeterYinusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FrederikBolding, I wondering if we should change it to a local Ganache server running on a different port. So we have more control over this in our tests

brad-decker
brad-decker previously approved these changes Jun 14, 2022
@brad-decker brad-decker force-pushed the fb/update-xdai-e2e-info branch from 71e3755 to b05ce65 Compare June 14, 2022 17:22
@metamaskbot
Copy link
Collaborator

Builds ready [abd5c78]
Page Load Metrics (1811 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891764193361173
domContentLoaded16092214178915976
load16092214181116077
domInteractive16092214178915976

@FrederikBolding FrederikBolding marked this pull request as ready for review June 15, 2022 09:15
@FrederikBolding FrederikBolding requested a review from a team as a code owner June 15, 2022 09:15
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work. And I agree with the decision to change this to use a local ganache server.

@FrederikBolding FrederikBolding merged commit 25aa3ab into develop Jun 15, 2022
@FrederikBolding FrederikBolding deleted the fb/update-xdai-e2e-info branch June 15, 2022 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants