-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Update E2E test for new test-dapp version #14939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PeterYinusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @FrederikBolding, I wondering if we should change it to a local Ganache server running on a different port. So we have more control over this in our tests
71e3755 to
b05ce65
Compare
Builds ready [abd5c78]Page Load Metrics (1811 ± 77 ms)
|
danjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work. And I agree with the decision to change this to use a local ganache server.
Explanation
Updates the
wallet_addEthereumChainE2E test to use a local Ganache instance instead of outdated XDAI RPC.More Information
To be merged with: MetaMask/test-dapp#174
Pre-Merge Checklist
+ If there are functional changes: