fix Chinese translation #14994
Merged
fix Chinese translation #14994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
reviewed
Jun 21, 2022
Contributor
darkwing
left a comment
darkwing
left a comment
There was a problem hiding this comment.
Google translates to:
This action will edit tokens already listed in your wallet and may be used to defraud you. Only pass this if you are sure you want to change the content of these tokens. Learn more about
Our English is:
This action will edit tokens that are already listed in your wallet, which can be used to phish you. Only approve if you are certain that you mean to change what these tokens represent. Learn more about
The changed verbiage: can be used to deceive you -> Can be used to deceive you
@du5 What's the reason for this change?
|
His answer is here: #14999 (comment) I posted this on slack too: https://consensys.slack.com/archives/C01DRUWDCFQ/p1656620514126949 |
|
We had someone review it here and the Chinese translation fix that is being proposed in this PR is correct. If everything else with the PR is good, we should approve it. |
darkwing
approved these changes
Jul 1, 2022
digiwand
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.