Skip to content

Conversation

@FrederikBolding
Copy link
Member

Explanation

Fixes a stringified object on the NFT approve screen. Since the title is a React object and not a string in case of "unknown NFTs" we need to render it as a React object instead of a string.

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

  1. Go to https://etherscan.io/address/0x1e52F7A450b08b1B249A4f4f54518fC5278C2285#writeContract
  2. Create a "setApprovalForAll" transaction to any address
  3. See that no stringified objects are present on the screen

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@FrederikBolding FrederikBolding requested a review from a team as a code owner July 20, 2022 09:55
@danjm danjm added this to the v10.18.0 milestone Jul 20, 2022
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@metamaskbot
Copy link
Collaborator

Builds ready [f5d86b7]
Page Load Metrics (1930 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint872161162814
domContentLoaded17152157190113465
load17322272193014369
domInteractive17152157190113465

highlights:

storybook

@danjm danjm merged commit 9e18149 into develop Jul 20, 2022
@danjm danjm deleted the fb/fix-nft-approve-text branch July 20, 2022 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants