Skip to content

Changelog 10.18.0 #15207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2022
Merged

Changelog 10.18.0 #15207

merged 3 commits into from
Jul 19, 2022

Conversation

@seaona
Copy link
Member

@seaona seaona commented Jul 13, 2022

Explanation

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jul 13, 2022

Builds ready [4f829bf]
Page Load Metrics (1752 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint80158106199
domContentLoaded15712110173814368
load15712110175215574
domInteractive15712110173814368

highlights:

storybook

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jul 13, 2022

Builds ready [51ea763]
Page Load Metrics (1794 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89149108147
domContentLoaded15712046177511656
load15912079179411455
domInteractive15712046177511656

highlights:

storybook

@seaona seaona requested review from danjm and ryanml July 13, 2022 18:20
@seaona seaona marked this pull request as ready for review July 13, 2022 19:11
@seaona seaona requested a review from a team as a code owner July 13, 2022 19:11
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jul 13, 2022

Builds ready [1920781]
Page Load Metrics (1890 ± 131 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881861202813
domContentLoaded159825171871259124
load159826331890272131
domInteractive159825171871259124

highlights:

storybook

ryanml
ryanml approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seaona seaona merged commit 1d34225 into Version-v10.18.0 Jul 19, 2022
@seaona seaona deleted the Version-v10.18.0-Changelog branch July 19, 2022 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danjm danjm Awaiting requested review from danjm

2 more reviewers

@brad-decker brad-decker brad-decker approved these changes

@ryanml ryanml ryanml approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seaona @metamaskbot @brad-decker @ryanml