-
Notifications
You must be signed in to change notification settings - Fork 5.4k
State logs e2e #15123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State logs e2e #15123
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [59f85f9]Page Load Metrics (1884 ± 57 ms)
|
Builds ready [67005c8]Page Load Metrics (1731 ± 76 ms)
|
| set -u | ||
| set -o pipefail | ||
|
|
||
| FIREFOX_VERSION='83.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to update this value? Shouldn't we keep this value at our min supported version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this was intentional, our min supported version is 68 for FF.
I updated this to be the latest FF release as most users are on the latest version(s).
I also needed to update the browser to be able to control the download directory of FF.
I've recently updated Chrome to the latest stable version #15015
Explanation
This PR adds an e2e test to ensure that the state logs can be downloaded from Settings -> Advanced
More Information
See: #14171
Screenshot
Screenshot showing the downloaded file in the CI pipeline
Chrome

Firefox
