Skip to content

Conversation

@PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Jul 1, 2022

Explanation

This PR adds an e2e test to ensure that the state logs can be downloaded from Settings -> Advanced

More Information

See: #14171

Screenshot

Screenshot showing the downloaded file in the CI pipeline

Chrome
State Logs

Firefox
State Logs FF

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [59f85f9]
Page Load Metrics (1884 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90154117199
domContentLoaded1663207418549244
load16842202188412057
domInteractive1663207418549244

@PeterYinusa PeterYinusa marked this pull request as ready for review July 1, 2022 09:59
@PeterYinusa PeterYinusa requested review from a team and kumavis as code owners July 1, 2022 09:59
@metamaskbot
Copy link
Collaborator

Builds ready [67005c8]
Page Load Metrics (1731 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891675190342164
domContentLoaded15622056172114469
load15632094173115976
domInteractive15622056172114469

set -u
set -o pipefail

FIREFOX_VERSION='83.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to update this value? Shouldn't we keep this value at our min supported version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was intentional, our min supported version is 68 for FF.
I updated this to be the latest FF release as most users are on the latest version(s).
I also needed to update the browser to be able to control the download directory of FF.
I've recently updated Chrome to the latest stable version #15015

@PeterYinusa PeterYinusa merged commit 4e1dbc6 into develop Jul 1, 2022
@PeterYinusa PeterYinusa deleted the state-logs-e2e branch July 1, 2022 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants