-
Notifications
You must be signed in to change notification settings - Fork 5.4k
State logs e2e #15123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
State logs e2e #15123
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| const { strict: assert } = require('assert'); | ||
| const { promises: fs } = require('fs'); | ||
| const { convertToHexValue, withFixtures } = require('../helpers'); | ||
|
|
||
| const downloadsFolder = `${process.cwd()}/test-artifacts/downloads`; | ||
|
|
||
| const createDownloadFolder = async () => { | ||
| await fs.rm(downloadsFolder, { recursive: true, force: true }); | ||
| await fs.mkdir(downloadsFolder, { recursive: true }); | ||
| }; | ||
|
|
||
| const stateLogsExist = async () => { | ||
| try { | ||
| const stateLogs = `${downloadsFolder}/MetaMask State Logs.json`; | ||
| await fs.access(stateLogs); | ||
| return true; | ||
| } catch (e) { | ||
| return false; | ||
| } | ||
| }; | ||
|
|
||
| describe('State logs', function () { | ||
| const ganacheOptions = { | ||
| accounts: [ | ||
| { | ||
| secretKey: | ||
| '0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC', | ||
| balance: convertToHexValue(25000000000000000000), | ||
| }, | ||
| ], | ||
| }; | ||
| it('should download state logs for the account', async function () { | ||
| await withFixtures( | ||
| { | ||
| fixtures: 'imported-account', | ||
| ganacheOptions, | ||
| title: this.test.title, | ||
| failOnConsoleError: false, | ||
| }, | ||
| async ({ driver }) => { | ||
| await createDownloadFolder(); | ||
| await driver.navigate(); | ||
| await driver.fill('#password', 'correct horse battery staple'); | ||
| await driver.press('#password', driver.Key.ENTER); | ||
|
|
||
| // Download State Logs | ||
| await driver.clickElement('.account-menu__icon'); | ||
| await driver.clickElement({ text: 'Settings', tag: 'div' }); | ||
| await driver.clickElement({ text: 'Advanced', tag: 'div' }); | ||
| await driver.clickElement({ | ||
| text: 'Download State Logs', | ||
| tag: 'button', | ||
| }); | ||
|
|
||
| // Verify download | ||
| let fileExists; | ||
| await driver.wait(async () => { | ||
| fileExists = await stateLogsExist(); | ||
| return fileExists === true; | ||
| }, 10000); | ||
| assert.equal(fileExists, true); | ||
| }, | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to update this value? Shouldn't we keep this value at our min supported version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this was intentional, our min supported version is 68 for FF.
I updated this to be the latest FF release as most users are on the latest version(s).
I also needed to update the browser to be able to control the download directory of FF.
I've recently updated Chrome to the latest stable version #15015