Skip to content

Conversation

@digiwand
Copy link
Contributor

Explanation

Unable to download state logs from Settings > Advanced. This PR updates getPlatformInfo the method to use the polyfill version

More information

Slack: https://consensys.slack.com/archives/GTQAGKY5V/p1648069151587819
Related PR: https://github.com/MetaMask/metamask-extension/pull/13960/files

Screenshots/Screencaps

Screen Shot 2022-03-23 at 4 52 08 PM

Screenshot 2022-03-23 at 7 05 28 PM

Manual testing steps

  • Go to Settings > Advanced
  • Click "Download State Logs"

@digiwand digiwand requested a review from a team as a code owner March 23, 2022 22:46
@digiwand digiwand requested a review from darkwing March 23, 2022 22:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand requested a review from adonesky1 March 23, 2022 22:47
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@digiwand
Copy link
Contributor Author

Teamwork makes the dream work! 😄 Credits to @adonesky1 @NiranjanaBinoy on this fix as well

@metamaskbot
Copy link
Collaborator

Builds ready [9f34425]
Page Load Metrics (1295 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711295201352169
domContentLoaded11681572129111756
load11791585129511756
domInteractive11681572129111756

@digiwand digiwand requested a review from NiranjanaBinoy March 24, 2022 14:01
@danjm
Copy link
Contributor

danjm commented Mar 25, 2022

merging, because I need state logs :)

@danjm danjm merged commit 69cba6d into develop Mar 25, 2022
@danjm danjm deleted the fix/settings-download-state-log branch March 25, 2022 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants