-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: L0 Delta - DataNode support write L0 segment #27675
Labels
Comments
This was referenced Oct 13, 2023
This was referenced Oct 24, 2023
sre-ci-robot
pushed a commit
that referenced
this issue
Jan 31, 2024
See also #27675 BloomFilterSet.current shall be reset after RollStats, otherwise it will keep tracking whole segment data causing the false positive ratio larger than expected. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this issue
Jan 31, 2024
) See also #27675 This PR adds back MemoryHighSyncPolicy implementation. Also change MinSegmentSize & CheckInterval to configurable param item. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
sre-ci-robot
pushed a commit
that referenced
this issue
Feb 5, 2024
See also #27675 #30469 For a sync task, the segment could be compacted during sync task. In previous implementation, this sync task will hold only the old segment id as KeyLock, in which case compaction on compacted to segment may run in parallel with delta sync of this sync task. This PR introduces sync target segment verification logic. It shall check target segment lock it's holding beforing actually syncing logic. If this check failed, sync task shall return`errTargetSegementNotMatch` error and make manager re-fetch the current target segment id. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Feb 6, 2024
Related to milvus-io#27675 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this issue
Feb 6, 2024
Related to #27675 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Apr 11, 2024
See also milvus-io#27675 milvus-io#26177 Make memory check evict memory buffer until memory water level is safe. Also make `EvictBuffer` wait until sync task done. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Apr 11, 2024
See also milvus-io#27675 milvus-io#26177 Make memory check evict memory buffer until memory water level is safe. Also make `EvictBuffer` wait until sync task done. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this issue
Apr 12, 2024
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Apr 12, 2024
See also milvus-io#27675 milvus-io#26177 Make memory check evict memory buffer until memory water level is safe. Also make `EvictBuffer` wait until sync task done. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Apr 28, 2024
Related to milvus-io#27675 Use `struct{}` instead `error` for sync task future result type to reduce result size and preventing logci error. Also change some unused parameter to `_` to suppress lint warning Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this issue
Apr 29, 2024
Related to #27675 Use `struct{}` instead `error` for sync task future result type to reduce result size and preventing logci error. Also change some unused parameter to `_` to suppress lint warning Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Jun 3, 2024
Related to milvus-io#27675 Store pk to minimal timestamp in `inData` instead of bloom filter to check whether some delete entry hit current insert batch Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this issue
Jun 4, 2024
Related to #27675 Store pk to minimal timestamp in `inData` instead of bloom filter to check whether some delete entry hit current insert batch Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Jun 4, 2024
Related to milvus-io#27675 Store pk to minimal timestamp in `inData` instead of bloom filter to check whether some delete entry hit current insert batch Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this issue
Jul 2, 2024
Related to milvus-io#27675 Store pk to minimal timestamp in `inData` instead of bloom filter to check whether some delete entry hit current insert batch Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this issue
Aug 22, 2024
Add back lazy loading statslog when watch dml channel on datanode. Related to milvus-io#22994 milvus-io#27675 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this issue
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is there an existing issue for this?
What would you like to be added?
Refactor datanode to support L0 segment sync
Segment
struct to buffer manager (with delta policy) AddWriteBuffer
to provided absbraction for delta policy #27874Why is this needed?
See also #27349
Anything else?
No response
The text was updated successfully, but these errors were encountered: